[LIBCLC][PTX] Fix logical bug in mul_hi for smaller datatypes (#4802)

hdelan · web-flow · commit f3a2f705a9d1 · 2021-10-22T20:26:03.000+03:00
Fixing logical bug in mul_hi for smaller datatypes
diff --git a/libclc/ptx-nvidiacl/libspirv/integer/mul_hi.cl b/libclc/ptx-nvidiacl/libspirv/integer/mul_hi.cl
@@ -30,7 +30,8 @@ _CLC_OVERLOAD _CLC_DEF ulong __spirv_ocl_u_mul_hi(ulong x, ulong y) {
 
 #define __CLC_MUL_HI_IMPL(BGENTYPE, SPV_MUL_HI, GENTYPE, GENSIZE)              \
   _CLC_OVERLOAD _CLC_DEF GENTYPE SPV_MUL_HI(GENTYPE x, GENTYPE y) {            \
-    return (GENTYPE)(SPV_MUL_HI((BGENTYPE)x, (BGENTYPE)y) >> GENSIZE);         \
+    return (GENTYPE)SPV_MUL_HI((BGENTYPE)(((BGENTYPE)x) << GENSIZE),           \
+                               (BGENTYPE)y);                                   \
   }
 
 __CLC_MUL_HI_IMPL(short, __spirv_ocl_s_mul_hi, char, 8)

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,8 @@ _CLC_OVERLOAD _CLC_DEF ulong __spirv_ocl_u_mul_hi(ulong x, ulong y) {`
`30`	`30`
`31`	`31`	`#define __CLC_MUL_HI_IMPL(BGENTYPE, SPV_MUL_HI, GENTYPE, GENSIZE) \`
`32`	`32`	`_CLC_OVERLOAD _CLC_DEF GENTYPE SPV_MUL_HI(GENTYPE x, GENTYPE y) { \`
`33`		`- return (GENTYPE)(SPV_MUL_HI((BGENTYPE)x, (BGENTYPE)y) >> GENSIZE); \`
	`33`	`+ return (GENTYPE)SPV_MUL_HI((BGENTYPE)(((BGENTYPE)x) << GENSIZE), \`
	`34`	`+ (BGENTYPE)y); \`
`34`	`35`	`}`
`35`	`36`
`36`	`37`	`__CLC_MUL_HI_IMPL(short, __spirv_ocl_s_mul_hi, char, 8)`