Skip to content

Commit f0f5518

Browse files
[SYCL][NFC] Remove FIXME comment (#6351)
kernel_arg_accessor_ptr metadata is conveying to the BE the requirement that argument be implemented using a surface. This is different from information conveyed by metadatas kernel_arg_exclusive_ptr and kernel_arg_runtime_aligned. Therefore, we cannot replace kernel_arg_accessor_ptr. Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
1 parent 558b3ba commit f0f5518

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

clang/lib/CodeGen/CodeGenModule.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1961,8 +1961,6 @@ void CodeGenModule::GenOpenCLArgMetadata(llvm::Function *Fn,
19611961
llvm::MDNode::get(VMContext, argBaseTypeNames));
19621962
Fn->setMetadata("kernel_arg_type_qual",
19631963
llvm::MDNode::get(VMContext, argTypeQuals));
1964-
// FIXME: What is the purpose of this metadata for ESIMD? Can we
1965-
// reuse kernel_arg_exclusive_ptr or kernel_arg_runtime_aligned ?
19661964
if (IsEsimdFunction)
19671965
Fn->setMetadata("kernel_arg_accessor_ptr",
19681966
llvm::MDNode::get(VMContext, argSYCLAccessorPtrs));

0 commit comments

Comments
 (0)