Skip to content

Commit e5676ad

Browse files
[SYCL][E2E] Update SPIR-V target requirement from SYCLBIN tests (#19227)
The SYCLBIN tests were only enabled for SPIR-V targets due to a bug in PTX builds with the new offload driver (#18432). Since this is believed to have been fixed, the requirements can be updated. --------- Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
1 parent 6d5fe22 commit e5676ad

10 files changed

+32
-46
lines changed

sycl/test-e2e/SYCLBIN/basic_executable.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@
1111
// -- Basic test for compiling and loading a SYCLBIN kernel_bundle in executable
1212
// -- state.
1313

14-
// Due to the regression in https://github.com/intel/llvm/issues/18432 it will
15-
// fail to build the SYCLBIN with nvptx targets. Once this is fixed,
16-
// %{sycl_target_opts} should be added to the SYCLBIN generation run-line.
17-
// REQUIRES: target-spir
14+
// SYCLBIN currently only properly detects SPIR-V binaries.
15+
// XFAIL: !target-spir
16+
// XFAIL-TRACKER: CMPLRLLVM-68811
1817

19-
// RUN: %clangxx --offload-new-driver -fsyclbin=executable %S/Inputs/basic_kernel.cpp -o %t.syclbin
18+
// RUN: %clangxx --offload-new-driver -fsyclbin=executable %{sycl_target_opts} %S/Inputs/basic_kernel.cpp -o %t.syclbin
2019
// RUN: %{build} -o %t.out
2120
// RUN: %{l0_leak_check} %{run} %t.out %t.syclbin
2221

sycl/test-e2e/SYCLBIN/basic_input.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@
1111
// -- Basic test for compiling and loading a SYCLBIN kernel_bundle in input
1212
// -- state.
1313

14-
// Due to the regression in https://github.com/intel/llvm/issues/18432 it will
15-
// fail to build the SYCLBIN with nvptx targets. Once this is fixed,
16-
// %{sycl_target_opts} should be added to the SYCLBIN generation run-line.
17-
// REQUIRES: target-spir
14+
// SYCLBIN currently only properly detects SPIR-V binaries.
15+
// XFAIL: !target-spir
16+
// XFAIL-TRACKER: CMPLRLLVM-68811
1817

19-
// RUN: %clangxx --offload-new-driver -fsyclbin=input %S/Inputs/basic_kernel.cpp -o %t.syclbin
18+
// RUN: %clangxx --offload-new-driver -fsyclbin=input %{sycl_target_opts} %S/Inputs/basic_kernel.cpp -o %t.syclbin
2019
// RUN: %{build} -o %t.out
2120
// RUN: %{l0_leak_check} %{run} %t.out %t.syclbin
2221

sycl/test-e2e/SYCLBIN/basic_object.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@
1111
// -- Basic test for compiling and loading a SYCLBIN kernel_bundle in object
1212
// -- state.
1313

14-
// Due to the regression in https://github.com/intel/llvm/issues/18432 it will
15-
// fail to build the SYCLBIN with nvptx targets. Once this is fixed,
16-
// %{sycl_target_opts} should be added to the SYCLBIN generation run-line.
17-
// REQUIRES: target-spir
14+
// SYCLBIN currently only properly detects SPIR-V binaries.
15+
// XFAIL: !target-spir
16+
// XFAIL-TRACKER: CMPLRLLVM-68811
1817

19-
// RUN: %clangxx --offload-new-driver -fsyclbin=object %S/Inputs/basic_kernel.cpp -o %t.syclbin
18+
// RUN: %clangxx --offload-new-driver -fsyclbin=object %{sycl_target_opts} %S/Inputs/basic_kernel.cpp -o %t.syclbin
2019
// RUN: %{build} -o %t.out
2120
// RUN: %{l0_leak_check} %{run} %t.out %t.syclbin
2221

sycl/test-e2e/SYCLBIN/link_input.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@
1010

1111
// -- Test for linking two SYCLBIN kernel_bundle.
1212

13-
// Due to the regression in https://github.com/intel/llvm/issues/18432 it will
14-
// fail to build the SYCLBIN with nvptx targets. Once this is fixed,
15-
// %{sycl_target_opts} should be added to the SYCLBIN generation run-line.
13+
// ptxas currently fails to compile images with unresolved symbols. Disable for
14+
// other targets than SPIR-V until this has been resolved. (CMPLRLLVM-68810)
15+
// Note: %{sycl_target_opts} should be added to the SYCLBIN compilation lines
16+
// once fixed.
1617
// REQUIRES: target-spir
1718

1819
// RUN: %clangxx --offload-new-driver -fsyclbin=input -fsycl-allow-device-image-dependencies %S/Inputs/exporting_function.cpp -o %t.export.syclbin

sycl/test-e2e/SYCLBIN/link_object.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@
1010

1111
// -- Test for linking two SYCLBIN kernel_bundle.
1212

13-
// Due to the regression in https://github.com/intel/llvm/issues/18432 it will
14-
// fail to build the SYCLBIN with nvptx targets. Once this is fixed,
15-
// %{sycl_target_opts} should be added to the SYCLBIN generation run-line.
13+
// ptxas currently fails to compile images with unresolved symbols. Disable for
14+
// other targets than SPIR-V until this has been resolved. (CMPLRLLVM-68810)
15+
// Note: %{sycl_target_opts} should be added to the SYCLBIN compilation lines
16+
// once fixed.
1617
// REQUIRES: target-spir
1718

1819
// RUN: %clangxx --offload-new-driver -fsyclbin=object -fsycl-allow-device-image-dependencies %S/Inputs/exporting_function.cpp -o %t.export.syclbin

sycl/test-e2e/SYCLBIN/link_rtc_input.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@
1515
// -- Test for linking where one kernel is runtime-compiled and one is compiled
1616
// -- to SYCLBIN.
1717

18-
// Due to the regression in https://github.com/intel/llvm/issues/18432 it will
19-
// fail to build the SYCLBIN with nvptx targets. Once this is fixed,
20-
// %{sycl_target_opts} should be added to the SYCLBIN generation run-line.
21-
// REQUIRES: target-spir
22-
2318
// RUN: %clangxx --offload-new-driver -fsyclbin=input -fsycl-allow-device-image-dependencies %S/Inputs/exporting_function.cpp -o %t.syclbin
2419
// RUN: %{build} -o %t.out
2520
// RUN: %{l0_leak_check} %{run} %t.out %t.syclbin

sycl/test-e2e/SYCLBIN/link_rtc_object.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@
1515
// -- Test for linking where one kernel is runtime-compiled and one is compiled
1616
// -- to SYCLBIN.
1717

18-
// Due to the regression in https://github.com/intel/llvm/issues/18432 it will
19-
// fail to build the SYCLBIN with nvptx targets. Once this is fixed,
20-
// %{sycl_target_opts} should be added to the SYCLBIN generation run-line.
21-
// REQUIRES: target-spir
22-
2318
// RUN: %clangxx --offload-new-driver -fsyclbin=object -fsycl-allow-device-image-dependencies %S/Inputs/exporting_function.cpp -o %t.syclbin
2419
// RUN: %{build} -o %t.out
2520
// RUN: %{l0_leak_check} %{run} %t.out %t.syclbin

sycl/test-e2e/SYCLBIN/optional_kernel_features_executable.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@
1111
// -- Test for compiling and loading a kernel bundle with a SYCLBIN containing
1212
// the use of optional kernel features.
1313

14-
// Due to the regression in https://github.com/intel/llvm/issues/18432 it will
15-
// fail to build the SYCLBIN with nvptx targets. Once this is fixed,
16-
// %{sycl_target_opts} should be added to the SYCLBIN generation run-line.
17-
// REQUIRES: target-spir
14+
// SYCLBIN currently only properly detects SPIR-V binaries.
15+
// XFAIL: !target-spir
16+
// XFAIL-TRACKER: CMPLRLLVM-68811
1817

19-
// RUN: %clangxx --offload-new-driver -fsyclbin=executable %S/Inputs/optional_kernel_features.cpp -o %t.syclbin
18+
// RUN: %clangxx --offload-new-driver -fsyclbin=executable %{sycl_target_opts} %S/Inputs/optional_kernel_features.cpp -o %t.syclbin
2019
// RUN: %{build} -o %t.out
2120
// RUN: %{l0_leak_check} %{run} %t.out %t.syclbin
2221

sycl/test-e2e/SYCLBIN/optional_kernel_features_input.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@
1111
// -- Test for compiling and loading a kernel bundle with a SYCLBIN containing
1212
// the use of optional kernel features.
1313

14-
// Due to the regression in https://github.com/intel/llvm/issues/18432 it will
15-
// fail to build the SYCLBIN with nvptx targets. Once this is fixed,
16-
// %{sycl_target_opts} should be added to the SYCLBIN generation run-line.
17-
// REQUIRES: target-spir
14+
// SYCLBIN currently only properly detects SPIR-V binaries.
15+
// XFAIL: !target-spir
16+
// XFAIL-TRACKER: CMPLRLLVM-68811
1817

19-
// RUN: %clangxx --offload-new-driver -fsyclbin=input %S/Inputs/optional_kernel_features.cpp -o %t.syclbin
18+
// RUN: %clangxx --offload-new-driver -fsyclbin=input %{sycl_target_opts} %S/Inputs/optional_kernel_features.cpp -o %t.syclbin
2019
// RUN: %{build} -o %t.out
2120
// RUN: %{l0_leak_check} %{run} %t.out %t.syclbin
2221

sycl/test-e2e/SYCLBIN/optional_kernel_features_object.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,11 @@
1212
// -- Test for compiling and loading a kernel bundle with a SYCLBIN containing
1313
// the use of optional kernel features.
1414

15-
// Due to the regression in https://github.com/intel/llvm/issues/18432 it will
16-
// fail to build the SYCLBIN with nvptx targets. Once this is fixed,
17-
// %{sycl_target_opts} should be added to the SYCLBIN generation run-line.
18-
// REQUIRES: target-spir
15+
// SYCLBIN currently only properly detects SPIR-V binaries.
16+
// XFAIL: !target-spir
17+
// XFAIL-TRACKER: CMPLRLLVM-68811
1918

20-
// RUN: %clangxx --offload-new-driver -fsyclbin=object %S/Inputs/optional_kernel_features.cpp -o %t.syclbin
19+
// RUN: %clangxx --offload-new-driver -fsyclbin=object %{sycl_target_opts} %S/Inputs/optional_kernel_features.cpp -o %t.syclbin
2120
// RUN: %{build} -o %t.out
2221
// RUN: %{l0_leak_check} %{run} %t.out %t.syclbin
2322

0 commit comments

Comments
 (0)