Skip to content

Commit e365f42

Browse files
authored
[libspirv] Remove scalar Dot, All and Any built-ins (#18110)
They only accept vector input per SPIR-V spec.
1 parent 229e955 commit e365f42

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

libclc/libspirv/lib/generic/geometric/dot.cl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include <libspirv/spirv.h>
1111

1212
#define _CLC_GEN_DOT(DECLSPEC, TYPE) \
13-
DECLSPEC TYPE __spirv_Dot(TYPE x, TYPE y) { return x * y; } \
13+
DECLSPEC static TYPE __spirv_Dot(TYPE x, TYPE y) { return x * y; } \
1414
DECLSPEC TYPE __spirv_Dot(TYPE##2 x, TYPE##2 y) { \
1515
return __spirv_Dot(x.x, y.x) + __spirv_Dot(x.y, y.y); \
1616
} \

libclc/libspirv/lib/generic/relational/all.cl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222

2323
#define ALL_ID(TYPE) _CLC_OVERLOAD _CLC_DEF bool __spirv_All(TYPE v)
2424

25-
bool __spirv_All(bool v) { return v; }
26-
2725
#define ALL_VECTORIZE(TYPE) \
2826
ALL_ID(TYPE##2) { return _CLC_ALL2(v); } \
2927
ALL_ID(TYPE##3) { return _CLC_ALL3(v); } \

libclc/libspirv/lib/generic/relational/any.cl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222

2323
#define ANY_ID(TYPE) _CLC_OVERLOAD _CLC_DEF bool __spirv_Any(TYPE v)
2424

25-
bool __spirv_Any(bool v) { return v; }
26-
2725
#define ANY_VECTORIZE(TYPE) \
2826
ANY_ID(TYPE##2) { return _CLC_ANY2(v); } \
2927
ANY_ID(TYPE##3) { return _CLC_ANY3(v); } \

0 commit comments

Comments
 (0)