Skip to content

Commit dcb975d

Browse files
authored
[SYCL] Add ext::intel::info::device::device_id to sycl-ls output (#15689)
The purpose of this change is to allow to mark with `// XFAIL: gpu-intel-pvc-1T` tests that are still failing exclusively on PVC T1. In this change, new information about the `device_id` was added to `sycl-ls --verbose` if device id is available.
1 parent 7bc2aae commit dcb975d

File tree

6 files changed

+26
-8
lines changed

6 files changed

+26
-8
lines changed

sycl/test-e2e/Plugin/level_zero_ext_intel_cslice.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
// REQUIRES: level_zero
22
// REQUIRES: aspect-ext_intel_device_id
3-
// https://github.com/intel/llvm/issues/14826
4-
// XFAIL: arch-intel_gpu_pvc
3+
4+
// XFAIL: gpu-intel-pvc-1T
5+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/15699
56

67
// RUN: %{build} -Wno-error=deprecated-declarations -o %t.out
78

sycl/test-e2e/Plugin/level_zero_ext_intel_queue_index.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
// REQUIRES: aspect-ext_intel_device_id
22
// REQUIRES: level_zero
33

4-
// https://github.com/intel/llvm/issues/14826
5-
// XFAIL: arch-intel_gpu_pvc
4+
// XFAIL: gpu-intel-pvc-1T
5+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/15699
6+
67
// RUN: %{build} -o %t.out
78

89
// TODO: at this time PVC 1T systems are not correctly supporting CSLICE

sycl/test-e2e/Plugin/level_zero_sub_sub_device.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// REQUIRES: arch-intel_gpu_pvc, level_zero
22

3-
// https://github.com/intel/llvm/issues/14826
43
// XFAIL: arch-intel_gpu_pvc
4+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/15602
55

66
// RUN: %{build} %level_zero_options -o %t.out
77

sycl/test-e2e/lit.cfg.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -430,8 +430,6 @@ def open_check_file(file_name):
430430
)
431431
sp = subprocess.check_output(cmd, text=True, shell=True)
432432
for line in sp.splitlines():
433-
if "Intel(R) Data Center GPU Max 1100" in line:
434-
config.available_features.add("gpu-intel-pvc-1T")
435433
if "gfx90a" in line:
436434
config.available_features.add("gpu-amd-gfx90a")
437435
if not line.startswith("["):
@@ -720,6 +718,15 @@ def open_check_file(file_name):
720718
# str.removeprefix isn't universally available...
721719
sg_sizes_str = line.strip().replace("info::device::sub_group_sizes: ", "")
722720
dev_sg_sizes.append(sg_sizes_str.strip().split(" "))
721+
if re.match(r" *DeviceID*", line):
722+
gpu_intel_pvc_1T_device_id = "3034"
723+
gpu_intel_pvc_2T_device_id = "3029"
724+
_, device_id = line.strip().split(":", 1)
725+
device_id = device_id.strip()
726+
if device_id == gpu_intel_pvc_1T_device_id:
727+
config.available_features.add("gpu-intel-pvc-1T")
728+
if device_id == gpu_intel_pvc_2T_device_id:
729+
config.available_features.add("gpu-intel-pvc-2T")
723730
if re.match(r" *Architecture:", line):
724731
_, architecture = line.strip().split(":", 1)
725732
architectures.add(architecture.strip())

sycl/test-e2e/no-xfail-without-tracker.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,4 @@
4747
// tests to match the required format and in that case you should just update
4848
// (i.e. reduce) the number below.
4949
//
50-
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 178
50+
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 175

sycl/tools/sycl-ls/sycl-ls.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,15 @@ static void printDeviceInfo(const device &Device, bool Verbose,
148148
std::cout << std::endl;
149149
}
150150

151+
// Get and print device ID, if it is available.
152+
if (Device.has(aspect::ext_intel_device_id)) {
153+
auto DeviceID =
154+
Device.get_info<sycl::ext::intel::info::device::device_id>();
155+
std::cout << Prepend << "DeviceID : " << DeviceID << std::endl;
156+
} else {
157+
std::cout << Prepend << "DeviceID : " << "UNKNOWN" << std::endl;
158+
}
159+
151160
// Print sub and sub-sub devices.
152161
{
153162
auto DevCount = GetNumberOfSubAndSubSubDevices(Device);

0 commit comments

Comments
 (0)