Skip to content

Commit c0b49db

Browse files
authored
[SYCL][NFC] Re-enable sycl.c test on Windows (#15433)
The issue dealt with the resetting of the PATH environment variable. This was masking potential runtime dependencies (DLLs and such) for other tools being used when running the test. The solution is to append the PATH for the dummy `aoc` instead of overwriting.
1 parent 9f53a78 commit c0b49db

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

clang/test/Driver/sycl.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
// Failing on Windows - temporarily disable
2-
// REQUIRES: system-linux
3-
41
// RUN: %clang -### -fsycl -c %s 2>&1 | FileCheck %s --check-prefix=ENABLED
52
// RUN: %clang -### -fsycl %s 2>&1 | FileCheck %s --check-prefix=ENABLED
63
// RUN: %clang -### -fno-sycl -fsycl %s 2>&1 | FileCheck %s --check-prefix=ENABLED
@@ -107,7 +104,7 @@
107104
// Test with a bad argument is expected to fail
108105
// RUN: not %clang -fsycl-help=foo %s 2>&1 | FileCheck %s --check-prefix=SYCL-HELP-BADARG
109106
// RUN: %clang -### -fsycl-help=gen %s 2>&1 | FileCheck %s --check-prefix=SYCL-HELP-GEN
110-
// RUN: env PATH=%t-sycl-dir %clang -### -fsycl-help=fpga %s 2>&1 | FileCheck %s --check-prefixes=SYCL-HELP-FPGA,SYCL-HELP-FPGA-OUT -DDIR=%t-sycl-dir
107+
// RUN: env "PATH=%t-sycl-dir%{pathsep}%PATH%" %clang -### -fsycl-help=fpga %s 2>&1 | FileCheck %s --check-prefixes=SYCL-HELP-FPGA,SYCL-HELP-FPGA-OUT -DDIR=%t-sycl-dir
111108
// RUN: %clang -### -fsycl-help=x86_64 %s 2>&1 | FileCheck %s --check-prefix=SYCL-HELP-CPU
112109
// RUN: %clang -### -fsycl-help %s 2>&1 | FileCheck %s --check-prefixes=SYCL-HELP-GEN,SYCL-HELP-FPGA,SYCL-HELP-CPU
113110
// SYCL-HELP-BADARG: unsupported argument 'foo' to option '-fsycl-help='

0 commit comments

Comments
 (0)