Skip to content

Commit b48a15a

Browse files
[SYCL][NFC] SYCL RT CMakeLists cleanup [2/N] (#17388)
This is one patch in a series intended to re-organize `add_sycl_rt_library` helper function to make it shorter and simpler. Dropped unnecessary `target_include_directories` calls: - `LIB_NAME` is a link-only target, no need to set any include directories for it - SYCL RT should not be using `unified-runtime/source` or `unified-runtime/source/common` includes
1 parent 09ad632 commit b48a15a

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

sycl/source/CMakeLists.txt

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,6 @@ function(add_sycl_rt_library LIB_NAME LIB_OBJ_NAME)
167167
${LLVM_EXTERNAL_SYCL_JIT_SOURCE_DIR}/jit-compiler/include)
168168
add_dependencies(${LIB_NAME} sycl-jit)
169169
add_dependencies(${LIB_OBJ_NAME} sycl-jit)
170-
target_include_directories(${LIB_NAME} PRIVATE ${SYCL_JIT_INCLUDE_DIRS})
171170
target_include_directories(${LIB_OBJ_NAME} PRIVATE ${SYCL_JIT_INCLUDE_DIRS})
172171
set_property(GLOBAL APPEND PROPERTY SYCL_TOOLCHAIN_INSTALL_COMPONENTS
173172
sycl-jit)
@@ -190,12 +189,6 @@ function(add_sycl_rt_library LIB_NAME LIB_OBJ_NAME)
190189
UnifiedRuntimeCommon
191190
)
192191

193-
target_include_directories(${LIB_OBJ_NAME}
194-
PRIVATE
195-
"${UNIFIED_RUNTIME_SRC_INCLUDE_DIR}"
196-
"${UNIFIED_RUNTIME_COMMON_INCLUDE_DIR}"
197-
)
198-
199192
target_link_libraries(${LIB_NAME}
200193
PRIVATE
201194
UnifiedRuntime-Headers
@@ -209,12 +202,6 @@ function(add_sycl_rt_library LIB_NAME LIB_OBJ_NAME)
209202
)
210203
endif()
211204

212-
target_include_directories(${LIB_NAME}
213-
PRIVATE
214-
"${UNIFIED_RUNTIME_SRC_INCLUDE_DIR}"
215-
"${UNIFIED_RUNTIME_COMMON_INCLUDE_DIR}"
216-
)
217-
218205
add_common_options(${LIB_NAME} ${LIB_OBJ_NAME})
219206

220207
set_target_properties(${LIB_NAME} PROPERTIES

0 commit comments

Comments
 (0)