Skip to content

Commit b3e8e43

Browse files
Quinn PhamQuinn Pham
authored andcommitted
[compiler-rt][NFC] Inclusive language: remove use of sanity check/test
from compiler-rt/lib/tsan [NFC] As part of using inclusive language within the llvm project, this patch rewords comments to remove sanity check and sanity test. Reviewed By: dvyukov Differential Revision: https://reviews.llvm.org/D124390
1 parent 7714e03 commit b3e8e43

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

compiler-rt/lib/tsan/go/test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88
//
9-
// Sanity test for Go runtime.
9+
// Test for Go runtime.
1010
//
1111
//===----------------------------------------------------------------------===//
1212

compiler-rt/lib/tsan/rtl-old/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ else()
172172
add_asm_sources(TSAN_ASM_SOURCES
173173
tsan_rtl_amd64.S
174174
)
175-
# Sanity check for Go runtime.
175+
# Check for Go runtime.
176176
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
177177
add_custom_target(GotsanRuntimeCheck
178178
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
@@ -186,7 +186,7 @@ else()
186186
add_asm_sources(TSAN_ASM_SOURCES
187187
tsan_rtl_aarch64.S
188188
)
189-
# Sanity check for Go runtime.
189+
# Check for Go runtime.
190190
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
191191
add_custom_target(GotsanRuntimeCheck
192192
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
@@ -200,7 +200,7 @@ else()
200200
add_asm_sources(TSAN_ASM_SOURCES
201201
tsan_rtl_ppc64.S
202202
)
203-
# Sanity check for Go runtime.
203+
# Check for Go runtime.
204204
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
205205
add_custom_target(GotsanRuntimeCheck
206206
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
@@ -218,7 +218,7 @@ else()
218218
add_asm_sources(TSAN_ASM_SOURCES
219219
tsan_rtl_s390x.S
220220
)
221-
# Sanity check for Go runtime.
221+
# Check for Go runtime.
222222
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
223223
add_custom_target(GotsanRuntimeCheck
224224
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"

compiler-rt/lib/tsan/rtl-old/tsan_flags.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ void InitializeFlags(Flags *f, const char *env, const char *env_option_name) {
9797
ubsan_parser.ParseStringFromEnv("UBSAN_OPTIONS");
9898
#endif
9999

100-
// Sanity check.
100+
// Check flags.
101101
if (!f->report_bugs) {
102102
f->report_thread_leaks = false;
103103
f->report_destroy_locked = false;

compiler-rt/lib/tsan/rtl/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ else()
169169
add_asm_sources(TSAN_ASM_SOURCES
170170
tsan_rtl_amd64.S
171171
)
172-
# Sanity check for Go runtime.
172+
# Check for Go runtime.
173173
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
174174
add_custom_target(GotsanRuntimeCheck
175175
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
@@ -183,7 +183,7 @@ else()
183183
add_asm_sources(TSAN_ASM_SOURCES
184184
tsan_rtl_aarch64.S
185185
)
186-
# Sanity check for Go runtime.
186+
# Check for Go runtime.
187187
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
188188
add_custom_target(GotsanRuntimeCheck
189189
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
@@ -197,7 +197,7 @@ else()
197197
add_asm_sources(TSAN_ASM_SOURCES
198198
tsan_rtl_ppc64.S
199199
)
200-
# Sanity check for Go runtime.
200+
# Check for Go runtime.
201201
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
202202
add_custom_target(GotsanRuntimeCheck
203203
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
@@ -215,7 +215,7 @@ else()
215215
add_asm_sources(TSAN_ASM_SOURCES
216216
tsan_rtl_s390x.S
217217
)
218-
# Sanity check for Go runtime.
218+
# Check for Go runtime.
219219
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
220220
add_custom_target(GotsanRuntimeCheck
221221
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"

compiler-rt/lib/tsan/rtl/tsan_flags.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ void InitializeFlags(Flags *f, const char *env, const char *env_option_name) {
9797
ubsan_parser.ParseStringFromEnv("UBSAN_OPTIONS");
9898
#endif
9999

100-
// Sanity check.
100+
// Check flags.
101101
if (!f->report_bugs) {
102102
f->report_thread_leaks = false;
103103
f->report_destroy_locked = false;

compiler-rt/lib/tsan/rtl/tsan_rtl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -936,7 +936,7 @@ void TraceSwitchPartImpl(ThreadState* thr) {
936936
// Pathologically large stacks may not fit into the part.
937937
// In these cases we log only fixed number of top frames.
938938
const uptr kMaxFrames = 1000;
939-
// Sanity check that kMaxFrames won't consume the whole part.
939+
// Check that kMaxFrames won't consume the whole part.
940940
static_assert(kMaxFrames < TracePart::kSize / 2, "kMaxFrames is too big");
941941
uptr* pos = Max(&thr->shadow_stack[0], thr->shadow_stack_pos - kMaxFrames);
942942
for (; pos < thr->shadow_stack_pos; pos++) {

0 commit comments

Comments
 (0)