Skip to content

Commit 9cd5a3b

Browse files
[SYCL] Fix minor Coverity issues with uninitialized variables (#15625)
This PR fixes Coverity hits due to potential use of uninitialized variables.
1 parent 9073865 commit 9cd5a3b

File tree

5 files changed

+18
-13
lines changed

5 files changed

+18
-13
lines changed

sycl/source/detail/bindless_images.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ alloc_image_mem(const image_descriptor &desc, const sycl::device &syclDevice,
171171
ur_image_format_t urFormat;
172172
populate_ur_structs(desc, urDesc, urFormat);
173173

174-
image_mem_handle retHandle;
174+
image_mem_handle retHandle = {};
175175

176176
// Call impl.
177177
Adapter->call<sycl::errc::memory_allocation,
@@ -201,7 +201,7 @@ __SYCL_EXPORT image_mem_handle get_mip_level_mem_handle(
201201
const sycl::detail::AdapterPtr &Adapter = CtxImpl->getAdapter();
202202

203203
// Call impl.
204-
image_mem_handle individual_image;
204+
image_mem_handle individual_image = {};
205205
Adapter->call<sycl::errc::runtime,
206206
sycl::detail::UrApiKind::urBindlessImagesMipmapGetLevelExp>(
207207
C, Device, mipMem.raw_handle, level, &individual_image.raw_handle);
@@ -284,7 +284,7 @@ create_image(image_mem_handle memHandle, const image_descriptor &desc,
284284
populate_ur_structs(desc, urDesc, urFormat);
285285

286286
// Call impl.
287-
ur_exp_image_mem_native_handle_t urImageHandle;
287+
ur_exp_image_mem_native_handle_t urImageHandle = 0;
288288
Adapter
289289
->call<sycl::errc::runtime,
290290
sycl::detail::UrApiKind::urBindlessImagesUnsampledImageCreateExp>(
@@ -421,7 +421,7 @@ create_image(void *devPtr, size_t pitch, const bindless_image_sampler &sampler,
421421
populate_ur_structs(desc, urDesc, urFormat, pitch);
422422

423423
// Call impl.
424-
ur_exp_image_mem_native_handle_t urImageHandle;
424+
ur_exp_image_mem_native_handle_t urImageHandle = 0;
425425
Adapter->call<sycl::errc::runtime,
426426
sycl::detail::UrApiKind::urBindlessImagesSampledImageCreateExp>(
427427
C, Device, reinterpret_cast<ur_exp_image_mem_native_handle_t>(devPtr),
@@ -550,7 +550,7 @@ image_mem_handle map_external_image_memory(external_mem extMem,
550550

551551
ur_exp_external_mem_handle_t urExternalMem{extMem.raw_handle};
552552

553-
image_mem_handle retHandle;
553+
image_mem_handle retHandle = {};
554554
Adapter->call<sycl::errc::invalid,
555555
sycl::detail::UrApiKind::urBindlessImagesMapExternalArrayExp>(
556556
C, Device, &urFormat, &urDesc, urExternalMem, &retHandle.raw_handle);
@@ -580,7 +580,7 @@ void *map_external_linear_memory(external_mem extMem, uint64_t offset,
580580

581581
ur_exp_external_mem_handle_t urExternalMem{extMem.raw_handle};
582582

583-
void *retMemory;
583+
void *retMemory = nullptr;
584584
Adapter->call<
585585
sycl::errc::invalid,
586586
sycl::detail::UrApiKind::urBindlessImagesMapExternalLinearMemoryExp>(
@@ -631,7 +631,7 @@ __SYCL_EXPORT external_semaphore import_external_semaphore(
631631
sycl::detail::getSyclObjImpl(syclDevice);
632632
ur_device_handle_t Device = DevImpl->getHandleRef();
633633

634-
ur_exp_external_semaphore_handle_t urExternalSemaphore;
634+
ur_exp_external_semaphore_handle_t urExternalSemaphore = nullptr;
635635
ur_exp_file_descriptor_t urFileDescriptor = {};
636636
urFileDescriptor.stype = UR_STRUCTURE_TYPE_EXP_FILE_DESCRIPTOR;
637637
urFileDescriptor.fd = externalSemaphoreDesc.external_resource.file_descriptor;
@@ -778,7 +778,7 @@ get_image_channel_type(const image_mem_handle memHandle,
778778
sycl::detail::getSyclObjImpl(syclContext);
779779
const sycl::detail::AdapterPtr &Adapter = CtxImpl->getAdapter();
780780

781-
ur_image_format_t URFormat;
781+
ur_image_format_t URFormat = {};
782782

783783
Adapter->call<sycl::errc::invalid,
784784
sycl::detail::UrApiKind::urBindlessImagesImageGetInfoExp>(

sycl/source/device.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,8 +234,8 @@ bool device::ext_oneapi_can_access_peer(const device &peer,
234234
return true;
235235
}
236236

237-
size_t returnSize;
238-
int value;
237+
size_t returnSize = 0;
238+
int value = 0;
239239

240240
ur_exp_peer_info_t UrAttr = [&]() {
241241
switch (attr) {

sycl/source/handler.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1862,7 +1862,12 @@ handler::getCommandGraph() const {
18621862
if (impl->MGraph) {
18631863
return impl->MGraph;
18641864
}
1865-
return MQueue->getCommandGraph();
1865+
1866+
if (this->MQueue)
1867+
return MQueue->getCommandGraph();
1868+
// We should never reach here. MGraph and MQueue can not be null
1869+
// simultaneously.
1870+
return nullptr;
18661871
}
18671872

18681873
void handler::setUserFacingNodeType(ext::oneapi::experimental::node_type Type) {

sycl/source/virtual_mem.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ __SYCL_EXPORT size_t get_mem_granularity(const device &SyclDevice,
4747
sycl::detail::getSyclObjImpl(SyclContext);
4848
const sycl::detail::AdapterPtr &Adapter = ContextImpl->getAdapter();
4949
#ifndef NDEBUG
50-
size_t InfoOutputSize;
50+
size_t InfoOutputSize = 0;
5151
Adapter->call<sycl::detail::UrApiKind::urVirtualMemGranularityGetInfo>(
5252
ContextImpl->getHandleRef(), DeviceImpl->getHandleRef(), GranularityQuery,
5353
0, nullptr, &InfoOutputSize);

xpti/include/xpti/xpti_data_types.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ struct payload_t {
436436
/// Kernel/lambda/function address
437437
const void *code_ptr_va = nullptr;
438438
/// Internal bookkeeping slot - do not change.
439-
uint64_t internal;
439+
uint64_t internal = 0;
440440
/// Flags indicating whether string name, codepointer, source file and hash
441441
/// values are available
442442
uint64_t flags = 0;

0 commit comments

Comments
 (0)