Skip to content

Commit 8039adc

Browse files
authored
[SYCL][SYCLLowerIR] Fix shared library build (#18290)
Shared library build is currently failing due to my change [here](#18249). The problem is the public build target dependencies of SYCLLowerIR didn't add the vc-intrinsics headers/binaries so the include/link fails. This wasn't happening before because users of SYCLLowerIR manually added the missing dependencies in their targets. Manually verified this on static/shared library build on both preinstalled vc-intrinsics and system vc-intrinsics. Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
1 parent 5b43c36 commit 8039adc

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

llvm/lib/SYCLLowerIR/CMakeLists.txt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,5 +115,9 @@ add_llvm_component_library(LLVMSYCLLowerIR
115115
)
116116

117117
target_include_directories(LLVMSYCLLowerIR
118-
PRIVATE ${LLVM_MAIN_SRC_DIR}/projects/vc-intrinsics/GenXIntrinsics/include
119-
PRIVATE ${LLVM_BINARY_DIR}/projects/vc-intrinsics/GenXIntrinsics/include)
118+
PUBLIC $<BUILD_INTERFACE:${LLVMGenXIntrinsics_SOURCE_DIR}/GenXIntrinsics/include/>
119+
PUBLIC $<BUILD_INTERFACE:${LLVMGenXIntrinsics_BINARY_DIR}>
120+
)
121+
target_link_libraries(LLVMSYCLLowerIR
122+
PUBLIC LLVMGenXIntrinsics
123+
)

0 commit comments

Comments
 (0)