Skip to content

Commit 77eea71

Browse files
MrSidimsdbudanov-cmplr
authored andcommitted
Remove ExecutionModeNamedBarrierCountINTEL from spirv_internal (#1604)
It was actually upstreamed to SPIR-V Headers already. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@3335c25
1 parent 5369a73 commit 77eea71

File tree

6 files changed

+6
-11
lines changed

6 files changed

+6
-11
lines changed

llvm-spirv/lib/SPIRV/PreprocessMetadata.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ void PreprocessMetadataBase::preprocessVectorComputeMetadata(Module *M,
357357
.getAsInteger(0, NBarrierCnt);
358358
EM.addOp()
359359
.add(&F)
360-
.add(spv::internal::ExecutionModeNamedBarrierCountINTEL)
360+
.add(spv::ExecutionModeNamedBarrierCountINTEL)
361361
.add(NBarrierCnt)
362362
.done();
363363
}

llvm-spirv/lib/SPIRV/SPIRVReader.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4206,8 +4206,7 @@ bool SPIRVToLLVM::transVectorComputeMetadata(SPIRVFunction *BF) {
42064206
F->addFnAttr(Attr);
42074207
}
42084208

4209-
if (auto *EM =
4210-
BF->getExecutionMode(internal::ExecutionModeNamedBarrierCountINTEL)) {
4209+
if (auto *EM = BF->getExecutionMode(ExecutionModeNamedBarrierCountINTEL)) {
42114210
unsigned int NBarrierCnt = EM->getLiterals()[0];
42124211
Attribute Attr = Attribute::get(*Context, kVCMetadata::VCNamedBarrierCount,
42134212
std::to_string(NBarrierCnt));

llvm-spirv/lib/SPIRV/SPIRVWriter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4572,7 +4572,7 @@ bool LLVMToSPIRVBase::transExecutionMode() {
45724572
BF->addExecutionMode(BM->add(new SPIRVExecutionMode(
45734573
BF, static_cast<ExecutionMode>(EMode), SLMSize)));
45744574
} break;
4575-
case spv::internal::ExecutionModeNamedBarrierCountINTEL: {
4575+
case spv::ExecutionModeNamedBarrierCountINTEL: {
45764576
if (!BM->isAllowedToUseExtension(ExtensionID::SPV_INTEL_vector_compute))
45774577
break;
45784578
unsigned NBarrierCnt = 0;

llvm-spirv/lib/SPIRV/libSPIRV/SPIRVEntry.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -580,7 +580,7 @@ void SPIRVExecutionMode::decode(std::istream &I) {
580580
case ExecutionModeFloatingPointModeALTINTEL:
581581
case ExecutionModeFloatingPointModeIEEEINTEL:
582582
case ExecutionModeSharedLocalMemorySizeINTEL:
583-
case internal::ExecutionModeNamedBarrierCountINTEL:
583+
case ExecutionModeNamedBarrierCountINTEL:
584584
case ExecutionModeSubgroupSize:
585585
case ExecutionModeMaxWorkDimINTEL:
586586
case ExecutionModeNumSIMDWorkitemsINTEL:

llvm-spirv/lib/SPIRV/libSPIRV/SPIRVEnum.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ template <> inline void SPIRVMap<SPIRVExecutionModeKind, SPIRVCapVec>::init() {
263263
{internal::CapabilityFastCompositeINTEL});
264264
ADD_VEC_INIT(internal::ExecutionModeStreamingInterfaceINTEL,
265265
{CapabilityFPGAKernelAttributesINTEL});
266-
ADD_VEC_INIT(internal::ExecutionModeNamedBarrierCountINTEL,
266+
ADD_VEC_INIT(ExecutionModeNamedBarrierCountINTEL,
267267
{CapabilityVectorComputeINTEL});
268268
}
269269

llvm-spirv/lib/SPIRV/libSPIRV/spirv_internal.hpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,7 @@ enum InternalFunctionControlMask { IFunctionControlOptNoneINTELMask = 0x10000 };
8585

8686
enum InternalExecutionMode {
8787
IExecModeFastCompositeKernelINTEL = 6088,
88-
IExecModeStreamingInterfaceINTEL = 6154,
89-
IExecModeNamedBarrierCountINTEL = 6417
88+
IExecModeStreamingInterfaceINTEL = 6154
9089
};
9190

9291
enum InternalLoopControlMask { ILoopControlLoopCountINTELMask = 0x1000000 };
@@ -185,9 +184,6 @@ constexpr ExecutionMode ExecutionModeFastCompositeKernelINTEL =
185184
constexpr ExecutionMode ExecutionModeStreamingInterfaceINTEL =
186185
static_cast<ExecutionMode>(IExecModeStreamingInterfaceINTEL);
187186

188-
constexpr ExecutionMode ExecutionModeNamedBarrierCountINTEL =
189-
static_cast<ExecutionMode>(IExecModeNamedBarrierCountINTEL);
190-
191187
static const LoopControlMask LoopControlLoopCountINTELMask =
192188
static_cast<LoopControlMask>(ILoopControlLoopCountINTELMask);
193189

0 commit comments

Comments
 (0)