Skip to content

Commit 70d1cff

Browse files
authored
[SYCL] Cleanup the way we lower SYCL attributes; NFC (#3144)
1 parent fc1e9dc commit 70d1cff

File tree

1 file changed

+13
-34
lines changed

1 file changed

+13
-34
lines changed

clang/lib/CodeGen/CGLoopInfo.cpp

Lines changed: 13 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1012,75 +1012,54 @@ void LoopInfoStack::push(BasicBlock *Header, clang::ASTContext &Ctx,
10121012
// emitted
10131013
// For attribute nofusion:
10141014
// 'llvm.loop.fusion.disable' metadata will be emitted
1015-
for (const auto *Attr : Attrs) {
1016-
const SYCLIntelFPGAIVDepAttr *IntelFPGAIVDep =
1017-
dyn_cast<SYCLIntelFPGAIVDepAttr>(Attr);
1018-
const SYCLIntelFPGAIIAttr *IntelFPGAII =
1019-
dyn_cast<SYCLIntelFPGAIIAttr>(Attr);
1020-
const SYCLIntelFPGAMaxConcurrencyAttr *IntelFPGAMaxConcurrency =
1021-
dyn_cast<SYCLIntelFPGAMaxConcurrencyAttr>(Attr);
1022-
const SYCLIntelFPGALoopCoalesceAttr *IntelFPGALoopCoalesce =
1023-
dyn_cast<SYCLIntelFPGALoopCoalesceAttr>(Attr);
1024-
const SYCLIntelFPGADisableLoopPipeliningAttr
1025-
*IntelFPGADisableLoopPipelining =
1026-
dyn_cast<SYCLIntelFPGADisableLoopPipeliningAttr>(Attr);
1027-
const SYCLIntelFPGAMaxInterleavingAttr *IntelFPGAMaxInterleaving =
1028-
dyn_cast<SYCLIntelFPGAMaxInterleavingAttr>(Attr);
1029-
const SYCLIntelFPGASpeculatedIterationsAttr *IntelFPGASpeculatedIterations =
1030-
dyn_cast<SYCLIntelFPGASpeculatedIterationsAttr>(Attr);
1031-
const SYCLIntelFPGANofusionAttr *IntelFPGANofusion =
1032-
dyn_cast<SYCLIntelFPGANofusionAttr>(Attr);
1033-
1034-
if (!IntelFPGAIVDep && !IntelFPGAII && !IntelFPGAMaxConcurrency &&
1035-
!IntelFPGALoopCoalesce && !IntelFPGADisableLoopPipelining &&
1036-
!IntelFPGAMaxInterleaving && !IntelFPGASpeculatedIterations &&
1037-
!IntelFPGANofusion)
1038-
continue;
1039-
1040-
if (IntelFPGAIVDep)
1015+
for (const auto *A : Attrs) {
1016+
if (const auto *IntelFPGAIVDep = dyn_cast<SYCLIntelFPGAIVDepAttr>(A))
10411017
addSYCLIVDepInfo(Header->getContext(), IntelFPGAIVDep->getSafelenValue(),
10421018
IntelFPGAIVDep->getArrayDecl());
10431019

1044-
if (IntelFPGAII)
1020+
if (const auto *IntelFPGAII = dyn_cast<SYCLIntelFPGAIIAttr>(A))
10451021
setSYCLIInterval(IntelFPGAII->getIntervalExpr()
10461022
->getIntegerConstantExpr(Ctx)
10471023
->getSExtValue());
10481024

1049-
if (IntelFPGAMaxConcurrency) {
1025+
if (const auto *IntelFPGAMaxConcurrency =
1026+
dyn_cast<SYCLIntelFPGAMaxConcurrencyAttr>(A)) {
10501027
setSYCLMaxConcurrencyEnable();
10511028
setSYCLMaxConcurrencyNThreads(IntelFPGAMaxConcurrency->getNThreadsExpr()
10521029
->getIntegerConstantExpr(Ctx)
10531030
->getSExtValue());
10541031
}
10551032

1056-
if (IntelFPGALoopCoalesce) {
1033+
if (const auto *IntelFPGALoopCoalesce =
1034+
dyn_cast<SYCLIntelFPGALoopCoalesceAttr>(A)) {
10571035
if (auto *LCE = IntelFPGALoopCoalesce->getNExpr())
10581036
setSYCLLoopCoalesceNLevels(
10591037
LCE->getIntegerConstantExpr(Ctx)->getSExtValue());
10601038
else
10611039
setSYCLLoopCoalesceEnable();
10621040
}
10631041

1064-
if (IntelFPGADisableLoopPipelining) {
1042+
if (isa<SYCLIntelFPGADisableLoopPipeliningAttr>(A))
10651043
setSYCLLoopPipeliningDisable();
1066-
}
10671044

1068-
if (IntelFPGAMaxInterleaving) {
1045+
if (const auto *IntelFPGAMaxInterleaving =
1046+
dyn_cast<SYCLIntelFPGAMaxInterleavingAttr>(A)) {
10691047
setSYCLMaxInterleavingEnable();
10701048
setSYCLMaxInterleavingNInvocations(IntelFPGAMaxInterleaving->getNExpr()
10711049
->getIntegerConstantExpr(Ctx)
10721050
->getSExtValue());
10731051
}
10741052

1075-
if (IntelFPGASpeculatedIterations) {
1053+
if (const auto *IntelFPGASpeculatedIterations =
1054+
dyn_cast<SYCLIntelFPGASpeculatedIterationsAttr>(A)) {
10761055
setSYCLSpeculatedIterationsEnable();
10771056
setSYCLSpeculatedIterationsNIterations(
10781057
IntelFPGASpeculatedIterations->getNExpr()
10791058
->getIntegerConstantExpr(Ctx)
10801059
->getSExtValue());
10811060
}
10821061

1083-
if (IntelFPGANofusion)
1062+
if (isa<SYCLIntelFPGANofusionAttr>(A))
10841063
setSYCLNofusionEnable();
10851064
}
10861065

0 commit comments

Comments
 (0)