Skip to content

Commit 5e45386

Browse files
authored
[CI][E2E] Run Windows Battlemage with prebuilt binaries (#18042)
Also disable tests that were flaky hanging in this configuration. When running fully on BMG tests took around 15min. With this change building e2e tests takes around 10m, and running the tests took around 6m. On paper this isn't any faster, however since we are spending less time on the BMG machine (which we currently only have one of in CI) this should improve the queue times for it. Additionally there is further opportunity to speed up the e2e build stage by moving it into the same job that builds the compiler, like we do for Linux.
1 parent 22e3e95 commit 5e45386

File tree

3 files changed

+7
-22
lines changed

3 files changed

+7
-22
lines changed

.github/workflows/sycl-windows-precommit.yml

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -79,30 +79,12 @@ jobs:
7979
include:
8080
- name: Intel GEN12 Graphics with Level Zero
8181
runner: '["Windows","gen12"]'
82-
uses: ./.github/workflows/sycl-windows-run-tests.yml
83-
with:
84-
name: ${{ matrix.name }}
85-
runner: ${{ matrix.runner }}
86-
sycl_toolchain_archive: ${{ needs.build.outputs.artifact_archive_name }}
87-
e2e_testing_mode: run-only
88-
e2e_binaries_artifact: sycl_windows_e2ebin
89-
90-
run_full_e2e_tests:
91-
needs: build
92-
# Continue if build was successful.
93-
if: |
94-
always()
95-
&& !cancelled()
96-
&& needs.build.outputs.build_conclusion == 'success'
97-
strategy:
98-
fail-fast: false
99-
matrix:
100-
include:
10182
- name: Intel Battlemage Graphics with Level Zero
10283
runner: '["Windows","bmg"]'
10384
uses: ./.github/workflows/sycl-windows-run-tests.yml
10485
with:
10586
name: ${{ matrix.name }}
10687
runner: ${{ matrix.runner }}
10788
sycl_toolchain_archive: ${{ needs.build.outputs.artifact_archive_name }}
108-
e2e_testing_mode: full
89+
e2e_testing_mode: run-only
90+
e2e_binaries_artifact: sycl_windows_e2ebin

sycl/test-e2e/Adapters/level_zero_eager_init.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
// UNSUPPORTED-INTENDED: ze_debug UR emits summary of leaks that contains
44
// function names that we match in the test.
55

6-
// XFAIL: windows && arch-intel_gpu_bmg_g21
7-
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/17165
6+
// UNSUPPORTED: windows && arch-intel_gpu_bmg_g21
7+
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/18067
88

99
// RUN: %{build} -Wno-error=deprecated-declarations %level_zero_options -o %t.out
1010
// RUN: env UR_L0_DEBUG=1 SYCL_EAGER_INIT=1 %{run} %t.out 2>&1 | FileCheck %s

sycl/test-e2e/Reduction/reduction_ctor.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
// RUN: %{build} -o %t.out
22
// RUN: %{run} %t.out
33

4+
// UNSUPPORTED: windows && arch-intel_gpu_bmg_g21 && (!build-mode && run-mode)
5+
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/17582
6+
47
// Windows doesn't yet have full shutdown().
58
// UNSUPPORTED: ze_debug && windows
69

0 commit comments

Comments
 (0)