Skip to content

Commit 49e1753

Browse files
committed
Mark baremetal.cpp test as unsupported on Windows.
A new check was added in 3b93dc6, which seems to not be possible to get working correctly on windows systems: The test first "captures" the install directory of the clang toolchain running the test as follows: // CHECK-AARCH64-NO-HOST-INC: InstalledDir: [[INSTALLEDDIR:.+]] Then, in a check line a bit later, it uses this to check if a particular directory in the toolchain installation directory is included when targeting aarch64-none-elf: // CHECK-AARCH64-NO-HOST-INC-SAME: "-internal-isystem" "[[INSTALLEDDIR]]{{[/\\]+}}..{{[/\\]+}}lib{{[/\\]+}}clang-runtimes{{[/\\]+}}aarch64-none-elf{{[/\\]+}}include{{[/\\]+}}c++{{[/\\]+}}v1" Even though the test aims to take into account forward vs backward slash differences between Windows and Unix paths, it still fails on Windows. It seems that on Windows (this is based on the output log from a Windows bot), the INSTALLEDDIR variable has the following value: note: with "INSTALLEDDIR" equal to "c:\\\\b\\\\slave\\\\clang-x64-windows-msvc\\\\build\\\\stage1\\\\bin" However the actual "InstalledDir:" output produced by the clang toolchain on that Windows bot was: InstalledDir: c:\b\slave\clang-x64-windows-msvc\build\stage1\bin It is unclear where the explosion of backslashes happens. Maybe this is a bug in FileCheck somewhere? Anyway, marking this test as not supported on Windows to make the bots green again.
1 parent 99a64cc commit 49e1753

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

clang/test/Driver/baremetal.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// UNSUPPORTED: system-windows
2+
13
// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
24
// RUN: -target armv6m-none-eabi \
35
// RUN: -T semihosted.lds \

0 commit comments

Comments
 (0)