Skip to content

Commit 40b78de

Browse files
authored
[SYCL][libdevice][NFC] Group cxxflags for imf libdevice host in imf_host_cxx_flags. (#6364)
In this PR, we group necessary cxxflags for imf libdevice host build in "imf_host_cxx_flags", so we only need to apply and change in one place. Signed-off-by: jinge90 <ge.jin@intel.com>
1 parent 4b1b01b commit 40b78de

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

libdevice/cmake/modules/SYCLLibdevice.cmake

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,9 @@ set(imf_fallback_fp64_deps device.h device_imf.hpp imf_half.hpp
129129
imf/imf_inline_fp64.cpp)
130130
set(imf_fp32_fallback_src ${imf_fallback_src_dir}/imf_fp32_fallback.cpp)
131131
set(imf_fp64_fallback_src ${imf_fallback_src_dir}/imf_fp64_fallback.cpp)
132-
132+
set(imf_host_cxx_flags -c
133+
-D__LIBDEVICE_HOST_IMPL__
134+
)
133135
add_custom_command(OUTPUT ${imf_fp32_fallback_src}
134136
COMMAND ${CMAKE_COMMAND} -D SRC_DIR=${imf_src_dir}
135137
-D DEST_DIR=${imf_fallback_src_dir}
@@ -162,7 +164,7 @@ add_custom_command(OUTPUT ${obj_binary_dir}/libsycl-fallback-imf.${lib-suffix}
162164
VERBATIM)
163165

164166
add_custom_command(OUTPUT ${obj_binary_dir}/fallback-imf-fp32-host.${lib-suffix}
165-
COMMAND ${clang} -c -D__LIBDEVICE_HOST_IMPL__
167+
COMMAND ${clang} ${imf_host_cxx_flags}
166168
-I ${CMAKE_CURRENT_SOURCE_DIR}/imf
167169
${imf_fp32_fallback_src}
168170
-o ${obj_binary_dir}/fallback-imf-fp32-host.${lib-suffix}
@@ -187,7 +189,7 @@ add_custom_command(OUTPUT ${obj_binary_dir}/libsycl-fallback-imf-fp64.${lib-suff
187189
VERBATIM)
188190

189191
add_custom_command(OUTPUT ${obj_binary_dir}/fallback-imf-fp64-host.${lib-suffix}
190-
COMMAND ${clang} -c -D__LIBDEVICE_HOST_IMPL__
192+
COMMAND ${clang} ${imf_host_cxx_flags}
191193
-I ${CMAKE_CURRENT_SOURCE_DIR}/imf
192194
${imf_fp64_fallback_src}
193195
-o ${obj_binary_dir}/fallback-imf-fp64-host.${lib-suffix}
@@ -207,15 +209,15 @@ add_dependencies(libsycldevice-spv imf_fallback_fp64_spv)
207209
add_dependencies(libsycldevice-obj imf_fallback_fp64_obj)
208210

209211
add_custom_command(OUTPUT ${obj_binary_dir}/imf-fp32-host.${lib-suffix}
210-
COMMAND ${clang} -c -D__LIBDEVICE_HOST_IMPL__
212+
COMMAND ${clang} ${imf_host_cxx_flags}
211213
${CMAKE_CURRENT_SOURCE_DIR}/imf_wrapper.cpp
212214
-o ${obj_binary_dir}/imf-fp32-host.${lib-suffix}
213215
MAIN_DEPENDENCY ${CMAKE_CURRENT_SOURCE_DIR}/imf_wrapper.cpp
214216
DEPENDS ${imf_obj_deps}
215217
VERBATIM)
216218

217219
add_custom_command(OUTPUT ${obj_binary_dir}/imf-fp64-host.${lib-suffix}
218-
COMMAND ${clang} -c -D__LIBDEVICE_HOST_IMPL__
220+
COMMAND ${clang} ${imf_host_cxx_flags}
219221
${CMAKE_CURRENT_SOURCE_DIR}/imf_wrapper_fp64.cpp
220222
-o ${obj_binary_dir}/imf-fp64-host.${lib-suffix}
221223
MAIN_DEPENDENCY ${CMAKE_CURRENT_SOURCE_DIR}/imf_wrapper_fp64.cpp

0 commit comments

Comments
 (0)