Skip to content

Commit 3ce5c04

Browse files
authored
Replace getAs with castAs, dyn_cast with cast (NFC) (#72600)
Make the code clear that nullptrs are not expected.
1 parent 6e31709 commit 3ce5c04

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

clang/lib/AST/ASTContext.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4014,8 +4014,8 @@ QualType ASTContext::getVectorType(QualType vecType, unsigned NumElts,
40144014
assert(vecType->isBuiltinType() ||
40154015
(vecType->isBitIntType() &&
40164016
// Only support _BitInt elements with byte-sized power of 2 NumBits.
4017-
llvm::isPowerOf2_32(vecType->getAs<BitIntType>()->getNumBits()) &&
4018-
vecType->getAs<BitIntType>()->getNumBits() >= 8));
4017+
llvm::isPowerOf2_32(vecType->castAs<BitIntType>()->getNumBits()) &&
4018+
vecType->castAs<BitIntType>()->getNumBits() >= 8));
40194019

40204020
// Check if we've already instantiated a vector of this type.
40214021
llvm::FoldingSetNodeID ID;

llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4402,7 +4402,7 @@ static void updateNVPTXMetadata(Function &Kernel, StringRef Name, int32_t Value,
44024402
// Update the "maxntidx" metadata for NVIDIA, or add it.
44034403
MDNode *ExistingOp = getNVPTXMDNode(Kernel, Name);
44044404
if (ExistingOp) {
4405-
auto *OldVal = dyn_cast<ConstantAsMetadata>(ExistingOp->getOperand(2));
4405+
auto *OldVal = cast<ConstantAsMetadata>(ExistingOp->getOperand(2));
44064406
int32_t OldLimit = cast<ConstantInt>(OldVal->getValue())->getZExtValue();
44074407
ExistingOp->replaceOperandWith(
44084408
2, ConstantAsMetadata::get(ConstantInt::get(
@@ -4441,7 +4441,7 @@ OpenMPIRBuilder::readThreadBoundsForKernel(const Triple &T, Function &Kernel) {
44414441
}
44424442

44434443
if (MDNode *ExistingOp = getNVPTXMDNode(Kernel, "maxntidx")) {
4444-
auto *OldVal = dyn_cast<ConstantAsMetadata>(ExistingOp->getOperand(2));
4444+
auto *OldVal = cast<ConstantAsMetadata>(ExistingOp->getOperand(2));
44454445
int32_t UB = cast<ConstantInt>(OldVal->getValue())->getZExtValue();
44464446
return {0, ThreadLimit ? std::min(ThreadLimit, UB) : UB};
44474447
}

0 commit comments

Comments
 (0)