Skip to content

Commit 38553eb

Browse files
[SYCL][CMAKE] Drop nodlopen from hardening flags (#19357)
We can't have this flag being applied globally, because it then affects SYCL RT which has plenty of libraries that are supposed to be `dlopen`ed by design. It probably makes sense to apply `nodlopen` for some of our executables, but that should be done on a case-by-case basis. For now, let's just fix the toolchain with hardening flags applied, any improvements can be done as a follow-up later.
1 parent 026d2b3 commit 38553eb

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

llvm/cmake/modules/AddSecurityFlags.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,6 @@ macro(append_common_extra_security_flags)
196196
if(CMAKE_BUILD_TYPE MATCHES "Release")
197197
add_link_option_ext("-Wl,-z,now" ZNOW CMAKE_EXE_LINKER_FLAGS
198198
CMAKE_MODULE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
199-
add_link_option_ext("-Wl,-z,nodlopen" ZDLOPEN CMAKE_EXE_LINKER_FLAGS
200-
CMAKE_MODULE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
201199
endif()
202200
endif()
203201
endmacro()

0 commit comments

Comments
 (0)