Skip to content

Commit 369666f

Browse files
authored
[UR][SYCL] Fix cmake LIST cache variables - LIST is not a valid cache type. (#17971)
This doesn't affect the behaviour of UR_EXTERNAL_DEPENDENCIES - since it gets used as a list, if you try to set it to a string that cmake can't convert to a list you get a fatal error (e.g. doing `set(UR_EXTERNAL_DEPENDENCIES "my-dep my-other-dep")` rather than `set(UR_EXTERNAL_DEPENDENCIES "my-dep;my-other-dep")`). The list of valid cache variable types is here https://cmake.org/cmake/help/latest/prop_cache/TYPE.html
1 parent 7c78048 commit 369666f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

sycl/cmake/modules/FetchUnifiedRuntime.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ set(UR_BUILD_XPTI_LIBS OFF)
3333
set(UR_ENABLE_SYMBOLIZER ON CACHE BOOL "Enable symbolizer for sanitizer layer.")
3434
set(UR_ENABLE_TRACING ON)
3535

36-
set(UR_EXTERNAL_DEPENDENCIES "sycl-headers" CACHE LIST
36+
set(UR_EXTERNAL_DEPENDENCIES "sycl-headers" CACHE STRING
3737
"List of external CMake targets for executables/libraries to depend on" FORCE)
3838

3939
if("level_zero" IN_LIST SYCL_ENABLE_BACKENDS)

unified-runtime/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ option(UR_BUILD_XPTI_LIBS "Build the XPTI libraries when tracing is enabled" ON)
5656
option(UR_STATIC_LOADER "Build loader as a static library" OFF)
5757
option(UR_FORCE_LIBSTDCXX "Force use of libstdc++ in a build using libc++ on Linux" OFF)
5858
option(UR_ENABLE_LATENCY_HISTOGRAM "Enable latncy histogram" OFF)
59-
set(UR_EXTERNAL_DEPENDENCIES "" CACHE LIST
59+
set(UR_EXTERNAL_DEPENDENCIES "" CACHE STRING
6060
"List of external CMake targets for executables/libraries to depend on")
6161
set(UR_DPCXX "" CACHE FILEPATH "Path of the DPC++ compiler executable")
6262
set(UR_DPCXX_BUILD_FLAGS "" CACHE STRING "Build flags to pass to DPC++ when compiling device programs")

0 commit comments

Comments
 (0)