Skip to content

Commit 340181f

Browse files
committed
[flang][openacc] Switch to use TODO from D88909
Use the Todo.h header file introduce in D88909 to marke part of the lowering that are not done yet. Reviewed By: jeanPerier Differential Revision: https://reviews.llvm.org/D88915
1 parent 89b7220 commit 340181f

File tree

1 file changed

+13
-8
lines changed

1 file changed

+13
-8
lines changed

flang/lib/Lower/OpenACC.cpp

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,12 @@
1616
#include "flang/Lower/FIRBuilder.h"
1717
#include "flang/Lower/PFTBuilder.h"
1818
#include "flang/Lower/Support/BoxValue.h"
19+
#include "flang/Lower/Todo.h"
1920
#include "flang/Parser/parse-tree.h"
2021
#include "flang/Semantics/tools.h"
2122
#include "mlir/Dialect/OpenACC/OpenACC.h"
2223
#include "llvm/Frontend/OpenACC/ACC.h.inc"
2324

24-
#define TODO() llvm_unreachable("not yet implemented")
25-
2625
static const Fortran::parser::Name *
2726
getDesignatorNameIfDataRef(const Fortran::parser::Designator &designator) {
2827
const auto *dataRef{std::get_if<Fortran::parser::DataRef>(&designator.u)};
@@ -528,22 +527,28 @@ void Fortran::lower::genOpenACCConstruct(
528527
genACC(converter, eval, blockConstruct);
529528
},
530529
[&](const Fortran::parser::OpenACCCombinedConstruct
531-
&combinedConstruct) { TODO(); },
530+
&combinedConstruct) {
531+
TODO("OpenACC Combined construct not lowered yet!");
532+
},
532533
[&](const Fortran::parser::OpenACCLoopConstruct &loopConstruct) {
533534
genACC(converter, eval, loopConstruct);
534535
},
535536
[&](const Fortran::parser::OpenACCStandaloneConstruct
536-
&standaloneConstruct) { TODO(); },
537+
&standaloneConstruct) {
538+
TODO("OpenACC Standalone construct not lowered yet!");
539+
},
537540
[&](const Fortran::parser::OpenACCRoutineConstruct
538-
&routineConstruct) { TODO(); },
541+
&routineConstruct) {
542+
TODO("OpenACC Routine construct not lowered yet!");
543+
},
539544
[&](const Fortran::parser::OpenACCCacheConstruct &cacheConstruct) {
540-
TODO();
545+
TODO("OpenACC Cache construct not lowered yet!");
541546
},
542547
[&](const Fortran::parser::OpenACCWaitConstruct &waitConstruct) {
543-
TODO();
548+
TODO("OpenACC Wait construct not lowered yet!");
544549
},
545550
[&](const Fortran::parser::OpenACCAtomicConstruct &atomicConstruct) {
546-
TODO();
551+
TODO("OpenACC Atomic construct not lowered yet!");
547552
},
548553
},
549554
accConstruct.u);

0 commit comments

Comments
 (0)