Skip to content

Commit 2307220

Browse files
authored
[CI] Fix Windows oneAPI test failures (#16758)
It was the math flags. We can't use `/Qno-intel-libs` and remove the env setup requirement from the e2e phase because of some insane linking errors I can't figure out and I don't think it's worth the time to investigate it any more. Closes: #16362 Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
1 parent 5f69e3e commit 2307220

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

.github/workflows/sycl-post-commit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ jobs:
104104
uses: ./.github/workflows/sycl-windows-build.yml
105105
with:
106106
compiler: icx
107-
build_configure_extra_args: --cmake-opt=-DCMAKE_C_FLAGS="/clang:-Wno-nonportable-include-path /clang:-Wno-cast-function-type-mismatch" --cmake-opt=-DCMAKE_CXX_FLAGS="/clang:-Wno-nonportable-include-path /clang:-Wno-cast-function-type-mismatch" --cmake-opt="-DCMAKE_EXE_LINKER_FLAGS=/manifest:no" --cmake-opt="-DCMAKE_MODULE_LINKER_FLAGS=/manifest:no" --cmake-opt="-DCMAKE_SHARED_LINKER_FLAGS=/manifest:no"
107+
build_configure_extra_args: --cmake-opt=-DCMAKE_C_FLAGS="/fp:precise /clang:-Wno-nonportable-include-path /clang:-Wno-cast-function-type-mismatch" --cmake-opt=-DCMAKE_CXX_FLAGS="/fp:precise /clang:-Wno-nonportable-include-path /clang:-Wno-cast-function-type-mismatch" --cmake-opt="-DCMAKE_EXE_LINKER_FLAGS=/manifest:no" --cmake-opt="-DCMAKE_MODULE_LINKER_FLAGS=/manifest:no" --cmake-opt="-DCMAKE_SHARED_LINKER_FLAGS=/manifest:no"
108108
build_cache_suffix: icx
109109
merge_ref: ''
110110

.github/workflows/sycl-windows-build.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -135,10 +135,7 @@ jobs:
135135
- name: check-llvm
136136
if: always() && !cancelled() && contains(inputs.changes, 'llvm')
137137
shell: bash
138-
run: |
139-
if [[ ${{inputs.compiler}} == 'icx' ]]; then
140-
export LIT_FILTER="SYCL"
141-
fi
138+
run: |
142139
cmake --build build --target check-llvm
143140
- name: check-clang
144141
if: always() && !cancelled() && contains(inputs.changes, 'clang')
@@ -147,10 +144,7 @@ jobs:
147144
- name: check-sycl
148145
if: always() && !cancelled() && contains(inputs.changes, 'sycl')
149146
shell: bash
150-
run: |
151-
if [[ ${{inputs.compiler}} == 'icx' ]]; then
152-
export LIT_XFAIL="regression\host_tanpi_double_accuracy.cpp"
153-
fi
147+
run: |
154148
cmake --build build --target check-sycl
155149
- name: check-sycl-unittests
156150
if: always() && !cancelled() && contains(inputs.changes, 'sycl')

0 commit comments

Comments
 (0)