Skip to content

Commit 1aa3a54

Browse files
committed
[clangd] Dont include version string in update tasks
This increases cardinality of span latency metrics. Currently this was being shown to the user via file status updates as `Running Update (x)` after this change we'll only display `Running Update`. This also affects logs in case of a crash, but contents and version number for inputs are printed separately in that case already. Differential Revision: https://reviews.llvm.org/D124013
1 parent 2d63354 commit 1aa3a54

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

clang-tools-extra/clangd/TUScheduler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -798,7 +798,7 @@ ASTWorker::~ASTWorker() {
798798

799799
void ASTWorker::update(ParseInputs Inputs, WantDiagnostics WantDiags,
800800
bool ContentChanged) {
801-
std::string TaskName = llvm::formatv("Update ({0})", Inputs.Version);
801+
llvm::StringLiteral TaskName = "Update";
802802
auto Task = [=]() mutable {
803803
// Get the actual command as `Inputs` does not have a command.
804804
// FIXME: some build systems like Bazel will take time to preparing

0 commit comments

Comments
 (0)