[SYCL][NFC] Code clean up revealed by compiler self build. (#2801)

The effort of compiler self build has revealed a number of errors that can be cleaned.

This is an effort to improve the code and reduce the errors.

Author: zahiraam

sycl/source/detail/os_util.cpp

@@ -170,7 +170,7 @@ std::string OSUtil::getDirName(const char* Path) {
   std::string Tmp(Path);
   // dirname(3) needs a writable C string: a null-terminator is written where a
   // path should split.
-  size_t TruncatedSize = strlen(dirname(const_cast<char*>(Tmp.c_str())));
+  size_t TruncatedSize = strlen(dirname(const_cast<char *>(Tmp.c_str())));
   Tmp.resize(TruncatedSize);
   return Tmp;
 }
@@ -196,7 +196,7 @@ std::string OSUtil::getCurrentDSODir() {
   char Path[MAX_PATH];
   Path[0] = '\0';
   Path[sizeof(Path) - 1] = '\0';
-  auto Handle = getOSModuleHandle(&getCurrentDSODir);
+  auto Handle = getOSModuleHandle(reinterpret_cast<void *>(&getCurrentDSODir));
   DWORD Ret = GetModuleFileNameA(
       reinterpret_cast<HMODULE>(OSUtil::ExeModuleHandle == Handle ? 0 : Handle),
       reinterpret_cast<LPSTR>(&Path), sizeof(Path));

sycl/source/detail/pi.cpp

@@ -303,8 +303,9 @@ static void initializePlugins(vector_class<plugin> *Plugins) {
     std::cerr << "SYCL_PI_TRACE[all]: "
               << "No Plugins Found." << std::endl;
 
-  PiPlugin PluginInformation{_PI_H_VERSION_STRING, _PI_H_VERSION_STRING,
-                             nullptr};
+  PiPlugin PluginInformation{
+      _PI_H_VERSION_STRING, _PI_H_VERSION_STRING, nullptr, {}};
+  PluginInformation.PiFunctionTable = {};
 
   for (unsigned int I = 0; I < PluginNames.size(); I++) {
     void *Library = loadPlugin(PluginNames[I].first);

sycl/source/detail/platform_impl.cpp

@@ -337,7 +337,7 @@ platform_impl::get_devices(info::device_type DeviceType) const {
   PlatformImplPtr PlatformImpl = getOrMakePlatformImpl(MPlatform, *MPlugin);
   std::transform(
       PiDevices.begin(), PiDevices.end(), std::back_inserter(Res),
-      [this, PlatformImpl](const RT::PiDevice &PiDevice) -> device {
+      [PlatformImpl](const RT::PiDevice &PiDevice) -> device {
         return detail::createSyclObjFromImpl<device>(
             PlatformImpl->getOrMakeDeviceImpl(PiDevice, PlatformImpl));
       });

sycl/source/detail/program_manager/program_manager.cpp

@@ -441,7 +441,7 @@ std::pair<RT::PiKernel, std::mutex *> ProgramManager::getOrCreateKernel(
       [&Program](const Locked<KernelCacheT> &LockedCache) -> KernelByNameT & {
     return LockedCache.get()[Program];
   };
-  auto BuildF = [this, &Program, &KernelName, &Ctx] {
+  auto BuildF = [&Program, &KernelName, &Ctx] {
     PiKernelT *Result = nullptr;
 
     // TODO need some user-friendly error/exception

sycl/source/detail/scheduler/graph_builder.cpp

@@ -508,10 +508,10 @@ Scheduler::GraphBuilder::findDepsForReq(MemObjRecord *Record,
   std::vector<Command *> Visited;
   const bool ReadOnlyReq = Req->MAccessMode == access::mode::read;
 
-  std::vector<Command *> ToAnalyze{std::move(Record->MWriteLeaves.toVector())};
+  std::vector<Command *> ToAnalyze{Record->MWriteLeaves.toVector()};
 
   if (!ReadOnlyReq) {
-    std::vector<Command *> V{std::move(Record->MReadLeaves.toVector())};
+    std::vector<Command *> V{Record->MReadLeaves.toVector()};
 
     ToAnalyze.insert(ToAnalyze.begin(), V.begin(), V.end());
   }
@@ -964,8 +964,7 @@ void Scheduler::GraphBuilder::cleanupCommandsForRecord(
     // Collect stream objects for a visited command.
     if (Cmd->getType() == Command::CommandType::RUN_CG) {
       auto ExecCmd = static_cast<ExecCGCommand *>(Cmd);
-      std::vector<std::shared_ptr<stream_impl>> Streams =
-          std::move(ExecCmd->getStreams());
+      std::vector<std::shared_ptr<stream_impl>> Streams = ExecCmd->getStreams();
       ExecCmd->clearStreams();
       StreamsToDeallocate.insert(StreamsToDeallocate.end(), Streams.begin(),
                                  Streams.end());
@@ -1026,8 +1025,7 @@ void Scheduler::GraphBuilder::cleanupFinishedCommands(
     // Collect stream objects for a visited command.
     if (Cmd->getType() == Command::CommandType::RUN_CG) {
       auto ExecCmd = static_cast<ExecCGCommand *>(Cmd);
-      std::vector<std::shared_ptr<stream_impl>> Streams =
-          std::move(ExecCmd->getStreams());
+      std::vector<std::shared_ptr<stream_impl>> Streams = ExecCmd->getStreams();
       ExecCmd->clearStreams();
       StreamsToDeallocate.insert(StreamsToDeallocate.end(), Streams.begin(),
                                  Streams.end());

sycl/source/detail/windows_pi.cpp

@@ -22,7 +22,8 @@ void *loadOsLibrary(const std::string &PluginPath) {
 }
 
 void *getOsLibraryFuncAddress(void *Library, const std::string &FunctionName) {
-  return GetProcAddress((HMODULE)Library, FunctionName.c_str());
+  return reinterpret_cast<void *>(
+      GetProcAddress((HMODULE)Library, FunctionName.c_str()));
 }
 
 } // namespace pi

xpti/src/xpti_proxy.cpp

@@ -113,7 +113,7 @@ class ProxyLoader {
 
   void *functionByIndex(int index) {
     if (index >= XPTI_INITIALIZE && index < XPTI_FW_API_COUNT) {
-      return m_dispatch_table[index];
+      return reinterpret_cast<void *>(m_dispatch_table[index]);
     }
     return nullptr;
   }