Skip to content

Commit e20be7e

Browse files
melhindilzha101
authored andcommitted
Update Makefile of dnnl for unattended installs
The proposed change makes it easier to perform unattended installations in e.g. docker containers or VMs. The `git am` command applies patches and attempts to commit the changes. Yet, in order to commit git requires `user.name` and `user.email` to be configured, which are both usually not set in containers or VMs. Based on my testing it is enough to simply apply the patch to avoid git asking for the user's name and email. Signed-off-by: Muhammad El-Hindi muhammad.el-hindi@cs.tu-darmstadt.com
1 parent b0af6e7 commit e20be7e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

external/dnnl/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,11 @@ dnnl_src:
8181
ifeq ($(shell git rev-parse --is-inside-work-tree), true)
8282
@$(RM) -r $(DNNL_DIR)/*
8383
git submodule update -f --init dnnl
84-
cd $(DNNL_DIR) && git am ../sgx_dnnl.patch
84+
cd $(DNNL_DIR) && git apply ../sgx_dnnl.patch
8585
else
8686
@$(RM) -r $(DNNL_DIR)
8787
git clone https://github.com/intel/mkl-dnn.git -b v1.1.1 --depth 1 $(DNNL_DIR)
88-
cd $(DNNL_DIR) && git am ../sgx_dnnl.patch
88+
cd $(DNNL_DIR) && git apply ../sgx_dnnl.patch
8989
endif
9090

9191
$(LIBDNNL):$(CHECK_SOURCE)

0 commit comments

Comments
 (0)