Skip to content

Commit 0746daa

Browse files
JunjunGu1lzha101
authored andcommitted
fix comments
Signed-off-by: junjungu <junjun.gu@intel.com>
1 parent 957ce93 commit 0746daa

File tree

2 files changed

+4
-44
lines changed

2 files changed

+4
-44
lines changed

psw/enclave_common/sgx_enclave_common.cpp

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -778,23 +778,7 @@ extern "C" void* COMM_API enclave_create_ex(
778778
s_enclave_mem_region[enclave_base].prot = 0;
779779
if(enclave_elrange != NULL)
780780
{
781-
enclave_elrange_t tmp_enclave_elrange;
782-
memset(&tmp_enclave_elrange, 0, sizeof(enclave_elrange_t));
783-
if (memcpy_s(&tmp_enclave_elrange, sizeof(enclave_elrange_t), enclave_elrange, sizeof(enclave_elrange_t)))
784-
{
785-
if (enclave_error)
786-
{
787-
*enclave_error = ENCLAVE_UNEXPECTED;
788-
}
789-
//if in-kernel driver then close the file handle
790-
if (s_driver_type == SGX_DRIVER_IN_KERNEL)
791-
{
792-
close_file(&hdevice_temp);
793-
}
794-
munmap(enclave_base, virtual_size);
795-
return NULL;
796-
}
797-
s_enclave_elrange_map[enclave_base] = tmp_enclave_elrange;
781+
s_enclave_elrange_map[enclave_base] = *enclave_elrange;
798782
}
799783
}
800784

@@ -1258,10 +1242,7 @@ extern "C" bool COMM_API enclave_delete(
12581242
s_hfile.erase(base_address);
12591243
}
12601244

1261-
if(s_enclave_elrange_map.count(base_address) != 0)
1262-
{
1263-
s_enclave_elrange_map.erase(base_address);
1264-
}
1245+
s_enclave_elrange_map.erase(base_address);
12651246
}
12661247

12671248
if (0 != munmap(base_address, enclave_size)) {

sdk/simulation/urtssim/enclave_creator_sim.cpp

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -106,25 +106,7 @@ int EnclaveCreatorSim::create_enclave(secs_t *secs, sgx_enclave_id_t *enclave_id
106106
enclave_elrange_t *tmp_enclave_elrange = reinterpret_cast<enclave_elrange_t *>(const_cast<void *>(ex_features_p[ENCLAVE_CREATE_EX_EL_RANGE_BIT_IDX]));
107107
void *base_address = reinterpret_cast<void*>(tmp_enclave_elrange->enclave_image_address);
108108
LockGuard lock(&s_enclave_info_mutex);
109-
if (s_enclave_elrange_map.count(base_address) != 0)
110-
{
111-
enclave_elrange_t enclave_elrange = s_enclave_elrange_map[base_address];
112-
113-
if (memcpy_s(&enclave_elrange, sizeof(enclave_elrange_t), tmp_enclave_elrange, sizeof(enclave_elrange_t)))
114-
{
115-
return SGX_ERROR_UNEXPECTED;
116-
}
117-
}
118-
else
119-
{
120-
enclave_elrange_t enclave_elrange;
121-
memset(&enclave_elrange, 0, sizeof(enclave_elrange_t));
122-
if (memcpy_s(&enclave_elrange, sizeof(enclave_elrange_t), tmp_enclave_elrange, sizeof(enclave_elrange_t)))
123-
{
124-
return SGX_ERROR_UNEXPECTED;
125-
}
126-
s_enclave_elrange_map[base_address] = enclave_elrange;
127-
}
109+
s_enclave_elrange_map[base_address] = *tmp_enclave_elrange;
128110
}
129111
return ::create_enclave(secs, enclave_id, start_addr);
130112
}
@@ -240,10 +222,7 @@ int EnclaveCreatorSim::destroy_enclave(sgx_enclave_id_t enclave_id, uint64_t enc
240222
if(enclave == NULL)
241223
return SGX_ERROR_INVALID_ENCLAVE_ID;
242224

243-
if(s_enclave_elrange_map.count(enclave->get_start_address()) != 0)
244-
{
245-
s_enclave_elrange_map.erase(enclave->get_start_address());
246-
}
225+
s_enclave_elrange_map.erase(enclave->get_start_address());
247226

248227
return ::destroy_enclave(enclave_id);
249228
}

0 commit comments

Comments
 (0)