Accept C files ending in a backslash-newline #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc accepts this with a warning and clang accepts it silently, but CBI exits with a RuntimeError. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
This parsing mode has never been enabled, and referring to it when parsing fails does not help end users. Instead, we should: - Treat any parsing failure as a bug; and - Selectively permit certain failures (with warnings). Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
laserkelvin
approved these changes
Apr 23, 2025
Ending the warning with a "." might result in a 404, if the terminal decides to treat that as part of the URL. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed changes
\, inspired by a header found in a Llama.cpp test.\).Enabling "relaxed" parsing mode would also have allowed the failing test to pass, but permitting any invalid code to proceed to future preprocessing phases seems like it would lead to errors that were almost impossible to debug. By providing an allowlist of permitted relaxed cases instead, we can generate a specific warning for each case and introduce additional relaxations over time.
I'll acknowledge that the way I've added a workaround for this specific case is a bit of a hack. A solution that detected
\at the end of a file and generated afilename:line:col:style warning immediately would be much better, butfile_sourceisn't set up to track tokens that way.Note that while removing the
relaxedparameter is a breaking change to these interfaces, directly calling the internals of thecodebasinpackage was deprecated in 1.2.0, so I don't think it's an issue.