Skip to content

Commit fd5625f

Browse files
pchelkin91jonmason
authored andcommitted
ntb: use 64-bit arithmetic for the MSI doorbell mask
msi_db_mask is of type 'u64', still the standard 'int' arithmetic is performed to compute its value. While most of the ntb_hw drivers actually don't utilize the higher 32 bits of the doorbell mask now, this may be the case for Switchtec - see switchtec_ntb_init_db(). Found by Linux Verification Center (linuxtesting.org) with SVACE static analysis tool. Fixes: 2b0569b ("NTB: Add MSI interrupt support to ntb_transport") Cc: stable@vger.kernel.org Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Jon Mason <jdmason@kudzu.us>
1 parent 1991934 commit fd5625f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/ntb/ntb_transport.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1353,7 +1353,7 @@ static int ntb_transport_probe(struct ntb_client *self, struct ntb_dev *ndev)
13531353
qp_count = ilog2(qp_bitmap);
13541354
if (nt->use_msi) {
13551355
qp_count -= 1;
1356-
nt->msi_db_mask = 1 << qp_count;
1356+
nt->msi_db_mask = BIT_ULL(qp_count);
13571357
ntb_db_clear_mask(ndev, nt->msi_db_mask);
13581358
}
13591359

0 commit comments

Comments
 (0)