Skip to content

Commit f8d1b01

Browse files
fdmananakdave
authored andcommitted
btrfs: always print transaction aborted messages with an error level
Commit b7af063 ("btrfs: print transaction aborted messages with an error level") changed the log level of transaction aborted messages from a debug level to an error level, so that such messages are always visible even on production systems where the log level is normally above the debug level (and also on some syzbot reports). Later, commit fccf0c8 ("btrfs: move btrfs_abort_transaction to transaction.c") changed the log level back to debug level when the error number for a transaction abort should not have a stack trace printed. This happened for absolutely no reason. It's always useful to print transaction abort messages with an error level, regardless of whether the error number should cause a stack trace or not. So change back the log level to error level. Fixes: fccf0c8 ("btrfs: move btrfs_abort_transaction to transaction.c") CC: stable@vger.kernel.org # 6.5+ Reviewed-by: Qu Wenruo <wqu@suse.com> Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
1 parent 5f52149 commit f8d1b01

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

fs/btrfs/transaction.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,8 +219,8 @@ do { \
219219
(errno))) { \
220220
/* Stack trace printed. */ \
221221
} else { \
222-
btrfs_debug((trans)->fs_info, \
223-
"Transaction aborted (error %d)", \
222+
btrfs_err((trans)->fs_info, \
223+
"Transaction aborted (error %d)", \
224224
(errno)); \
225225
} \
226226
} \

0 commit comments

Comments
 (0)