Skip to content

Commit f25a51b

Browse files
perexgtiwai
authored andcommitted
ALSA: compress_offload: use safe list iteration in snd_compr_task_seq()
The sequence function can call snd_compr_task_free_one(). Use list_for_each_entry_safe_reverse() to make sure that the used pointers are safe. Link: https://lore.kernel.org/linux-sound/f2769cff-6c7a-4092-a2d1-c33a5411a182@stanley.mountain/ Fixes: 0417715 ("ALSA: compress_offload: introduce accel operation mode") Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Cc: Vinod Koul <vkoul@kernel.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz> Signed-off-by: Takashi Iwai <tiwai@suse.de> Link: https://patch.msgid.link/20241217100707.732766-1-perex@perex.cz
1 parent 6018f2f commit f25a51b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

sound/core/compress_offload.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1174,7 +1174,7 @@ typedef void (*snd_compr_seq_func_t)(struct snd_compr_stream *stream,
11741174
static int snd_compr_task_seq(struct snd_compr_stream *stream, unsigned long arg,
11751175
snd_compr_seq_func_t fcn)
11761176
{
1177-
struct snd_compr_task_runtime *task;
1177+
struct snd_compr_task_runtime *task, *temp;
11781178
__u64 seqno;
11791179
int retval;
11801180

@@ -1185,7 +1185,7 @@ static int snd_compr_task_seq(struct snd_compr_stream *stream, unsigned long arg
11851185
return -EFAULT;
11861186
retval = 0;
11871187
if (seqno == 0) {
1188-
list_for_each_entry_reverse(task, &stream->runtime->tasks, list)
1188+
list_for_each_entry_safe_reverse(task, temp, &stream->runtime->tasks, list)
11891189
fcn(stream, task);
11901190
} else {
11911191
task = snd_compr_find_task(stream, seqno);

0 commit comments

Comments
 (0)