Skip to content

Commit e860513

Browse files
vsyrjalajlahtine-intel
authored andcommitted
drm/i915/dp: Fix colorimetry detection
intel_dp_init_connector() is no place for detecting stuff via DPCD (except perhaps for eDP). Move the colorimetry stuff into a more appropriate place. Cc: Jouni Högander <jouni.hogander@intel.com> Fixes: 0007667 ("drm/i915/display: Move colorimetry_support from intel_psr to intel_dp") Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240918190441.29071-1-ville.syrjala@linux.intel.com Reviewed-by: Jouni Högander <jouni.hogander@intel.com> (cherry picked from commit 35dba48) Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
1 parent d7126c0 commit e860513

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

drivers/gpu/drm/i915/display/intel_dp.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4067,6 +4067,9 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp, struct intel_connector *connector
40674067
drm_dp_is_branch(intel_dp->dpcd));
40684068
intel_init_dpcd_quirks(intel_dp, &intel_dp->desc.ident);
40694069

4070+
intel_dp->colorimetry_support =
4071+
intel_dp_get_colorimetry_status(intel_dp);
4072+
40704073
/*
40714074
* Read the eDP display control registers.
40724075
*
@@ -4180,6 +4183,9 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp)
41804183

41814184
intel_init_dpcd_quirks(intel_dp, &intel_dp->desc.ident);
41824185

4186+
intel_dp->colorimetry_support =
4187+
intel_dp_get_colorimetry_status(intel_dp);
4188+
41834189
intel_dp_update_sink_caps(intel_dp);
41844190
}
41854191

@@ -6931,9 +6937,6 @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
69316937
"HDCP init failed, skipping.\n");
69326938
}
69336939

6934-
intel_dp->colorimetry_support =
6935-
intel_dp_get_colorimetry_status(intel_dp);
6936-
69376940
intel_dp->frl.is_trained = false;
69386941
intel_dp->frl.trained_rate_gbps = 0;
69396942

0 commit comments

Comments
 (0)