Skip to content

Commit e4975ac

Browse files
arighihtejun
authored andcommitted
sched_ext: update scx_bpf_dsq_insert() doc for SCX_DSQ_LOCAL_ON
With commit 5b26f7b ("sched_ext: Allow SCX_DSQ_LOCAL_ON for direct dispatches"), scx_bpf_dsq_insert() can use SCX_DSQ_LOCAL_ON for direct dispatch from ops.enqueue() to target the local DSQ of any CPU. Update the documentation accordingly. Fixes: 5b26f7b ("sched_ext: Allow SCX_DSQ_LOCAL_ON for direct dispatches") Signed-off-by: Andrea Righi <arighi@nvidia.com> Signed-off-by: Tejun Heo <tj@kernel.org>
1 parent d9071ec commit e4975ac

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

Documentation/scheduler/sched-ext.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -242,9 +242,9 @@ The following briefly shows how a waking task is scheduled and executed.
242242
task was inserted directly from ``ops.select_cpu()``). ``ops.enqueue()``
243243
can make one of the following decisions:
244244

245-
* Immediately insert the task into either the global or local DSQ by
246-
calling ``scx_bpf_dsq_insert()`` with ``SCX_DSQ_GLOBAL`` or
247-
``SCX_DSQ_LOCAL``, respectively.
245+
* Immediately insert the task into either the global or a local DSQ by
246+
calling ``scx_bpf_dsq_insert()`` with one of the following options:
247+
``SCX_DSQ_GLOBAL``, ``SCX_DSQ_LOCAL``, or ``SCX_DSQ_LOCAL_ON | cpu``.
248248

249249
* Immediately insert the task into a custom DSQ by calling
250250
``scx_bpf_dsq_insert()`` with a DSQ ID which is smaller than 2^63.

kernel/sched/ext.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6406,9 +6406,7 @@ __bpf_kfunc_start_defs();
64066406
* ops.select_cpu(), and ops.dispatch().
64076407
*
64086408
* When called from ops.select_cpu() or ops.enqueue(), it's for direct dispatch
6409-
* and @p must match the task being enqueued. Also, %SCX_DSQ_LOCAL_ON can't be
6410-
* used to target the local DSQ of a CPU other than the enqueueing one. Use
6411-
* ops.select_cpu() to be on the target CPU in the first place.
6409+
* and @p must match the task being enqueued.
64126410
*
64136411
* When called from ops.select_cpu(), @enq_flags and @dsp_id are stored, and @p
64146412
* will be directly inserted into the corresponding dispatch queue after

0 commit comments

Comments
 (0)