Skip to content

Commit e4476cd

Browse files
cristiccrobertfoss
authored andcommitted
drm/bridge: dw-hdmi: Sync comment block with actual bus formats order
Commit d3d6b1b ("drm: bridge: dw_hdmi: fix preference of RGB modes over YUV420") changed the order of the output bus formats, but missed to update accordingly the "Possible output formats" comment section above dw_hdmi_bridge_atomic_get_output_bus_fmts(). Fix the misleading comment block and a context related typo. Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Robert Foss <rfoss@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20250204-dw-hdmi-bus-fmt-order-v2-1-d0aaeb7a697a@collabora.com
1 parent 0e9cb79 commit e4476cd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2621,6 +2621,7 @@ static int dw_hdmi_connector_create(struct dw_hdmi *hdmi)
26212621
* - MEDIA_BUS_FMT_UYYVYY12_0_5X36,
26222622
* - MEDIA_BUS_FMT_UYYVYY10_0_5X30,
26232623
* - MEDIA_BUS_FMT_UYYVYY8_0_5X24,
2624+
* - MEDIA_BUS_FMT_RGB888_1X24,
26242625
* - MEDIA_BUS_FMT_YUV16_1X48,
26252626
* - MEDIA_BUS_FMT_RGB161616_1X48,
26262627
* - MEDIA_BUS_FMT_UYVY12_1X24,
@@ -2631,7 +2632,6 @@ static int dw_hdmi_connector_create(struct dw_hdmi *hdmi)
26312632
* - MEDIA_BUS_FMT_RGB101010_1X30,
26322633
* - MEDIA_BUS_FMT_UYVY8_1X16,
26332634
* - MEDIA_BUS_FMT_YUV8_1X24,
2634-
* - MEDIA_BUS_FMT_RGB888_1X24,
26352635
*/
26362636

26372637
/* Can return a maximum of 11 possible output formats for a mode/connector */
@@ -2669,7 +2669,7 @@ static u32 *dw_hdmi_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge,
26692669
}
26702670

26712671
/*
2672-
* If the current mode enforces 4:2:0, force the output but format
2672+
* If the current mode enforces 4:2:0, force the output bus format
26732673
* to 4:2:0 and do not add the YUV422/444/RGB formats
26742674
*/
26752675
if (conn->ycbcr_420_allowed &&

0 commit comments

Comments
 (0)