Skip to content

Commit e3603cc

Browse files
author
Steve French
committed
smb3: Add dynamic trace points for RDMA (smbdirect) reconnect
smb3_smbd_connect_done and smb3_smbd_connect_err To improve debugging of RDMA issues add those two. We already had dynamic tracepoints for non-RDMA connect done and error cases. Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent ce9ecca commit e3603cc

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

fs/smb/client/smbdirect.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1401,10 +1401,13 @@ int smbd_reconnect(struct TCP_Server_Info *server)
14011401
server->smbd_conn = smbd_get_connection(
14021402
server, (struct sockaddr *) &server->dstaddr);
14031403

1404-
if (server->smbd_conn)
1404+
if (server->smbd_conn) {
14051405
cifs_dbg(VFS, "RDMA transport re-established\n");
1406-
1407-
return server->smbd_conn ? 0 : -ENOENT;
1406+
trace_smb3_smbd_connect_done(server->hostname, server->conn_id, &server->dstaddr);
1407+
return 0;
1408+
}
1409+
trace_smb3_smbd_connect_err(server->hostname, server->conn_id, &server->dstaddr);
1410+
return -ENOENT;
14081411
}
14091412

14101413
static void destroy_caches_and_workqueue(struct smbd_connection *info)

fs/smb/client/trace.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -935,6 +935,8 @@ DEFINE_EVENT(smb3_connect_class, smb3_##name, \
935935
TP_ARGS(hostname, conn_id, addr))
936936

937937
DEFINE_SMB3_CONNECT_EVENT(connect_done);
938+
DEFINE_SMB3_CONNECT_EVENT(smbd_connect_done);
939+
DEFINE_SMB3_CONNECT_EVENT(smbd_connect_err);
938940

939941
DECLARE_EVENT_CLASS(smb3_connect_err_class,
940942
TP_PROTO(char *hostname, __u64 conn_id,

0 commit comments

Comments
 (0)