Skip to content

Commit e2158c9

Browse files
Kaustabh Chakrabortyvinodkoul
authored andcommitted
phy: exynos5-usbdrd: fix MPLL_MULTIPLIER and SSC_REFCLKSEL masks in refclk
In exynos5_usbdrd_{pipe3,utmi}_set_refclk(), the masks PHYCLKRST_MPLL_MULTIPLIER_MASK and PHYCLKRST_SSC_REFCLKSEL_MASK are not inverted when applied to the register values. Fix it. Cc: stable@vger.kernel.org Fixes: 5902588 ("phy: Add new Exynos5 USB 3.0 PHY driver") Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Anand Moon <linux.amoon@gmail.com> Link: https://lore.kernel.org/r/20250209-exynos5-usbdrd-masks-v1-1-4f7f83f323d7@disroot.org Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent fd75f37 commit e2158c9

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

drivers/phy/samsung/phy-exynos5-usbdrd.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -488,9 +488,9 @@ exynos5_usbdrd_pipe3_set_refclk(struct phy_usb_instance *inst)
488488
reg |= PHYCLKRST_REFCLKSEL_EXT_REFCLK;
489489

490490
/* FSEL settings corresponding to reference clock */
491-
reg &= ~PHYCLKRST_FSEL_PIPE_MASK |
492-
PHYCLKRST_MPLL_MULTIPLIER_MASK |
493-
PHYCLKRST_SSC_REFCLKSEL_MASK;
491+
reg &= ~(PHYCLKRST_FSEL_PIPE_MASK |
492+
PHYCLKRST_MPLL_MULTIPLIER_MASK |
493+
PHYCLKRST_SSC_REFCLKSEL_MASK);
494494
switch (phy_drd->extrefclk) {
495495
case EXYNOS5_FSEL_50MHZ:
496496
reg |= (PHYCLKRST_MPLL_MULTIPLIER_50M_REF |
@@ -532,9 +532,9 @@ exynos5_usbdrd_utmi_set_refclk(struct phy_usb_instance *inst)
532532
reg &= ~PHYCLKRST_REFCLKSEL_MASK;
533533
reg |= PHYCLKRST_REFCLKSEL_EXT_REFCLK;
534534

535-
reg &= ~PHYCLKRST_FSEL_UTMI_MASK |
536-
PHYCLKRST_MPLL_MULTIPLIER_MASK |
537-
PHYCLKRST_SSC_REFCLKSEL_MASK;
535+
reg &= ~(PHYCLKRST_FSEL_UTMI_MASK |
536+
PHYCLKRST_MPLL_MULTIPLIER_MASK |
537+
PHYCLKRST_SSC_REFCLKSEL_MASK);
538538
reg |= PHYCLKRST_FSEL(phy_drd->extrefclk);
539539

540540
return reg;

0 commit comments

Comments
 (0)