Skip to content

Commit dcf9969

Browse files
vsyrjalaAndi Shyti
authored andcommitted
drm/i915: Use REG_BIT() & co. for CHV EU/slice fuse bits
Convert the CHV EU/slice fuse bits to the modern REG_BIT()/etc. style. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250211231941.22769-8-ville.syrjala@linux.intel.com
1 parent 5e3e23b commit dcf9969

File tree

2 files changed

+15
-23
lines changed

2 files changed

+15
-23
lines changed

drivers/gpu/drm/i915/gt/intel_gt_regs.h

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -937,12 +937,12 @@
937937
#define CHV_POWER_SS0_SIG1 _MMIO(0xa720)
938938
#define CHV_POWER_SS0_SIG2 _MMIO(0xa724)
939939
#define CHV_POWER_SS1_SIG1 _MMIO(0xa728)
940-
#define CHV_SS_PG_ENABLE (1 << 1)
941-
#define CHV_EU08_PG_ENABLE (1 << 9)
942-
#define CHV_EU19_PG_ENABLE (1 << 17)
943-
#define CHV_EU210_PG_ENABLE (1 << 25)
940+
#define CHV_SS_PG_ENABLE REG_BIT(1)
941+
#define CHV_EU08_PG_ENABLE REG_BIT(9)
942+
#define CHV_EU19_PG_ENABLE REG_BIT(17)
943+
#define CHV_EU210_PG_ENABLE REG_BIT(25)
944944
#define CHV_POWER_SS1_SIG2 _MMIO(0xa72c)
945-
#define CHV_EU311_PG_ENABLE (1 << 1)
945+
#define CHV_EU311_PG_ENABLE REG_BIT(1)
946946

947947
#define GEN7_SARCHKMD _MMIO(0xb000)
948948
#define GEN7_DISABLE_DEMAND_PREFETCH (1 << 31)
@@ -1440,16 +1440,12 @@
14401440
#define XEHP_CCS_MODE_CSLICE(cslice, ccs) (ccs << (cslice * XEHP_CCS_MODE_CSLICE_WIDTH))
14411441

14421442
#define CHV_FUSE_GT _MMIO(VLV_GUNIT_BASE + 0x2168)
1443-
#define CHV_FGT_DISABLE_SS0 (1 << 10)
1444-
#define CHV_FGT_DISABLE_SS1 (1 << 11)
1445-
#define CHV_FGT_EU_DIS_SS0_R0_SHIFT 16
1446-
#define CHV_FGT_EU_DIS_SS0_R0_MASK (0xf << CHV_FGT_EU_DIS_SS0_R0_SHIFT)
1447-
#define CHV_FGT_EU_DIS_SS0_R1_SHIFT 20
1448-
#define CHV_FGT_EU_DIS_SS0_R1_MASK (0xf << CHV_FGT_EU_DIS_SS0_R1_SHIFT)
1449-
#define CHV_FGT_EU_DIS_SS1_R0_SHIFT 24
1450-
#define CHV_FGT_EU_DIS_SS1_R0_MASK (0xf << CHV_FGT_EU_DIS_SS1_R0_SHIFT)
1451-
#define CHV_FGT_EU_DIS_SS1_R1_SHIFT 28
1452-
#define CHV_FGT_EU_DIS_SS1_R1_MASK (0xf << CHV_FGT_EU_DIS_SS1_R1_SHIFT)
1443+
#define CHV_FGT_DISABLE_SS0 REG_BIT(10)
1444+
#define CHV_FGT_DISABLE_SS1 REG_BIT(11)
1445+
#define CHV_FGT_EU_DIS_SS0_R0_MASK REG_GENMASK(19, 16)
1446+
#define CHV_FGT_EU_DIS_SS0_R1_MASK REG_GENMASK(23, 20)
1447+
#define CHV_FGT_EU_DIS_SS1_R0_MASK REG_GENMASK(27, 24)
1448+
#define CHV_FGT_EU_DIS_SS1_R1_MASK REG_GENMASK(31, 28)
14531449

14541450
#define BCS_SWCTRL _MMIO(0x22200)
14551451
#define BCS_SRC_Y REG_BIT(0)

drivers/gpu/drm/i915/gt/intel_sseu.c

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -335,21 +335,17 @@ static void cherryview_sseu_info_init(struct intel_gt *gt)
335335

336336
if (!(fuse & CHV_FGT_DISABLE_SS0)) {
337337
u8 disabled_mask =
338-
((fuse & CHV_FGT_EU_DIS_SS0_R0_MASK) >>
339-
CHV_FGT_EU_DIS_SS0_R0_SHIFT) |
340-
(((fuse & CHV_FGT_EU_DIS_SS0_R1_MASK) >>
341-
CHV_FGT_EU_DIS_SS0_R1_SHIFT) << 4);
338+
REG_FIELD_GET(CHV_FGT_EU_DIS_SS0_R0_MASK, fuse) |
339+
REG_FIELD_GET(CHV_FGT_EU_DIS_SS0_R1_MASK, fuse) << hweight32(CHV_FGT_EU_DIS_SS0_R0_MASK);
342340

343341
sseu->subslice_mask.hsw[0] |= BIT(0);
344342
sseu_set_eus(sseu, 0, 0, ~disabled_mask & 0xFF);
345343
}
346344

347345
if (!(fuse & CHV_FGT_DISABLE_SS1)) {
348346
u8 disabled_mask =
349-
((fuse & CHV_FGT_EU_DIS_SS1_R0_MASK) >>
350-
CHV_FGT_EU_DIS_SS1_R0_SHIFT) |
351-
(((fuse & CHV_FGT_EU_DIS_SS1_R1_MASK) >>
352-
CHV_FGT_EU_DIS_SS1_R1_SHIFT) << 4);
347+
REG_FIELD_GET(CHV_FGT_EU_DIS_SS1_R0_MASK, fuse) |
348+
REG_FIELD_GET(CHV_FGT_EU_DIS_SS1_R1_MASK, fuse) << hweight32(CHV_FGT_EU_DIS_SS1_R0_MASK);
353349

354350
sseu->subslice_mask.hsw[0] |= BIT(1);
355351
sseu_set_eus(sseu, 0, 1, ~disabled_mask & 0xFF);

0 commit comments

Comments
 (0)