Skip to content

Commit d988b0b

Browse files
lweiss-fairphoneandersson
authored andcommitted
clk: qcom: gpucc-sm6350: Add *_wait_val values for GDSCs
Compared to the msm-4.19 driver the mainline GDSC driver always sets the bits for en_rest, en_few & clk_dis, and if those values are not set per-GDSC in the respective driver then the default value from the GDSC driver is used. The downstream driver only conditionally sets clk_dis_wait_val if qcom,clk-dis-wait-val is given in devicetree. Correct this situation by explicitly setting those values. For all GDSCs the reset value of those bits are used, with the exception of gpu_cx_gdsc which has an explicit value (qcom,clk-dis-wait-val = <8>). Fixes: 013804a ("clk: qcom: Add GPU clock controller driver for SM6350") Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Reviewed-by: Taniya Das <quic_tdas@quicinc.com> Link: https://lore.kernel.org/r/20250425-sm6350-gdsc-val-v1-4-1f252d9c5e4e@fairphone.com Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent afdfd82 commit d988b0b

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/clk/qcom/gpucc-sm6350.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -413,6 +413,9 @@ static struct clk_branch gpu_cc_gx_vsense_clk = {
413413
static struct gdsc gpu_cx_gdsc = {
414414
.gdscr = 0x106c,
415415
.gds_hw_ctrl = 0x1540,
416+
.en_rest_wait_val = 0x2,
417+
.en_few_wait_val = 0x2,
418+
.clk_dis_wait_val = 0x8,
416419
.pd = {
417420
.name = "gpu_cx_gdsc",
418421
},
@@ -423,6 +426,9 @@ static struct gdsc gpu_cx_gdsc = {
423426
static struct gdsc gpu_gx_gdsc = {
424427
.gdscr = 0x100c,
425428
.clamp_io_ctrl = 0x1508,
429+
.en_rest_wait_val = 0x2,
430+
.en_few_wait_val = 0x2,
431+
.clk_dis_wait_val = 0x2,
426432
.pd = {
427433
.name = "gpu_gx_gdsc",
428434
.power_on = gdsc_gx_do_nothing_enable,

0 commit comments

Comments
 (0)