Skip to content

Commit d861a5d

Browse files
committed
Merge branch 'mptcp-pm-defer-freeing-userspace-pm-entries'
Matthieu Baerts says: ==================== mptcp: pm: Defer freeing userspace pm entries Here are two unrelated fixes for MPTCP: - Patch 1: free userspace PM entry with RCU helpers. A fix for v6.14. - Patch 2: avoid a warning when running diag.sh selftest. A fix for v6.15-rc1. ==================== Link: https://patch.msgid.link/20250421-net-mptcp-pm-defer-freeing-v1-0-e731dc6e86b9@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2 parents 491ef11 + ce72fea commit d861a5d

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

net/mptcp/pm_userspace.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,11 @@ int mptcp_pm_nl_remove_doit(struct sk_buff *skb, struct genl_info *info)
337337

338338
release_sock(sk);
339339

340-
sock_kfree_s(sk, match, sizeof(*match));
340+
kfree_rcu_mightsleep(match);
341+
/* Adjust sk_omem_alloc like sock_kfree_s() does, to match
342+
* with allocation of this memory by sock_kmemdup()
343+
*/
344+
atomic_sub(sizeof(*match), &sk->sk_omem_alloc);
341345

342346
err = 0;
343347
out:

tools/testing/selftests/net/mptcp/diag.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,9 +206,8 @@ chk_dump_one()
206206
local token
207207
local msg
208208

209-
ss_token="$(ss -inmHMN $ns | grep 'token:' |\
210-
head -n 1 |\
211-
sed 's/.*token:\([0-9a-f]*\).*/\1/')"
209+
ss_token="$(ss -inmHMN $ns |
210+
mptcp_lib_get_info_value "token" "token")"
212211

213212
token="$(ip netns exec $ns ./mptcp_diag -t $ss_token |\
214213
awk -F':[ \t]+' '/^token/ {print $2}')"

0 commit comments

Comments
 (0)