Skip to content

Commit d7b0bef

Browse files
nicbretztytso
authored andcommitted
ext4: on a remount, only log the ro or r/w state when it has changed
A user complained that a message such as: EXT4-fs (nvme0n1p3): re-mounted UUID ro. Quota mode: none. implied that the file system was previously mounted read/write and was now remounted read-only, when it could have been some other mount state that had changed by the "mount -o remount" operation. Fix this by only logging "ro"or "r/w" when it has changed. https://bugzilla.kernel.org/show_bug.cgi?id=219132 Signed-off-by: Nicolas Bretz <bretznic@gmail.com> Link: https://patch.msgid.link/20250319171011.8372-1-bretznic@gmail.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
1 parent 129245c commit d7b0bef

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

fs/ext4/super.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6780,6 +6780,7 @@ static int ext4_reconfigure(struct fs_context *fc)
67806780
{
67816781
struct super_block *sb = fc->root->d_sb;
67826782
int ret;
6783+
bool old_ro = sb_rdonly(sb);
67836784

67846785
fc->s_fs_info = EXT4_SB(sb);
67856786

@@ -6791,9 +6792,9 @@ static int ext4_reconfigure(struct fs_context *fc)
67916792
if (ret < 0)
67926793
return ret;
67936794

6794-
ext4_msg(sb, KERN_INFO, "re-mounted %pU %s. Quota mode: %s.",
6795-
&sb->s_uuid, sb_rdonly(sb) ? "ro" : "r/w",
6796-
ext4_quota_mode(sb));
6795+
ext4_msg(sb, KERN_INFO, "re-mounted %pU%s.",
6796+
&sb->s_uuid,
6797+
(old_ro != sb_rdonly(sb)) ? (sb_rdonly(sb) ? " ro" : " r/w") : "");
67976798

67986799
return 0;
67996800
}

0 commit comments

Comments
 (0)