Skip to content

Commit d450cdd

Browse files
juhosgbroonie
authored andcommitted
spi: spi-qpic-snand: avoid memleak in qcom_spi_ecc_init_ctx_pipelined()
When the allocation of the OOB buffer fails, the qcom_spi_ecc_init_ctx_pipelined() function returns without freeing the memory allocated for 'ecc_cfg' thus it can cause a memory leak. Call kfree() to free 'ecc_cfg' before returning from the function to avoid that. Fixes: 7304d19 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface") Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> Link: https://patch.msgid.link/20250313-qpic-snand-memleak-fix-v1-1-e54e78d1da3a@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 5a5fc30 commit d450cdd

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/spi/spi-qpic-snand.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,8 +263,10 @@ static int qcom_spi_ecc_init_ctx_pipelined(struct nand_device *nand)
263263
return -ENOMEM;
264264
snandc->qspi->oob_buf = kzalloc(mtd->writesize + mtd->oobsize,
265265
GFP_KERNEL);
266-
if (!snandc->qspi->oob_buf)
266+
if (!snandc->qspi->oob_buf) {
267+
kfree(ecc_cfg);
267268
return -ENOMEM;
269+
}
268270

269271
memset(snandc->qspi->oob_buf, 0xff, mtd->writesize + mtd->oobsize);
270272

0 commit comments

Comments
 (0)