Skip to content

Commit d32c4e5

Browse files
geertubroonie
authored andcommitted
spi: SPI_QPIC_SNAND should be tristate and depend on MTD
SPI_QPIC_SNAND is the only driver that selects MTD instead of depending on it, which could lead to circular dependencies. Moreover, as SPI_QPIC_SNAND is bool, this forces MTD (and various related symbols) to be built-in, as can be seen in an allmodconfig kernel. Except for a missing semicolon, there is no reason why SPI_QPIC_SNAND cannot be tristate; all MODULE_*() boilerplate is already present. Hence make SPI_QPIC_SNAND tristate, let it depend on MTD, and add the missing semicolon. Fixes: 7304d19 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://patch.msgid.link/b63db431cbf35223a4400e44c296293d32c4543c.1742998909.git.geert+renesas@glider.be Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 7a874e8 commit d32c4e5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

drivers/spi/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -937,9 +937,9 @@ config SPI_QCOM_QSPI
937937
QSPI(Quad SPI) driver for Qualcomm QSPI controller.
938938

939939
config SPI_QPIC_SNAND
940-
bool "QPIC SNAND controller"
940+
tristate "QPIC SNAND controller"
941941
depends on ARCH_QCOM || COMPILE_TEST
942-
select MTD
942+
depends on MTD
943943
help
944944
QPIC_SNAND (QPIC SPI NAND) driver for Qualcomm QPIC controller.
945945
QPIC controller supports both parallel nand and serial nand.

drivers/spi/spi-qpic-snand.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1614,7 +1614,7 @@ static const struct of_device_id qcom_snandc_of_match[] = {
16141614
.data = &ipq9574_snandc_props,
16151615
},
16161616
{}
1617-
}
1617+
};
16181618
MODULE_DEVICE_TABLE(of, qcom_snandc_of_match);
16191619

16201620
static struct platform_driver qcom_spi_driver = {

0 commit comments

Comments
 (0)