Skip to content

Commit d2677d5

Browse files
committed
PM: runtime: Drop status check from pm_runtime_force_resume()
Since pm_runtime_force_resume() requires pm_runtime_force_suspend() to be called before it on the same device, the runtime PM status of the device is RPM_SUSPENDED when it is called unless the device's runtime PM status is changed somewhere else in the meantime. However, even if that happens, the power.needs_force_resume check is still required to pass and that flag is only set by pm_runtime_force_suspend() once and it is cleared at the end of pm_runtime_force_resume(), so it cannot be taken into account twice in a row. According to the above, the pm_runtime_status_suspended(dev) check in pm_runtime_force_resume() is redundant, so drop it. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Link: https://patch.msgid.link/2309120.iZASKD2KPV@rjwysocki.net
1 parent 258e231 commit d2677d5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/base/power/runtime.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1945,7 +1945,7 @@ int pm_runtime_force_resume(struct device *dev)
19451945
int (*callback)(struct device *);
19461946
int ret = 0;
19471947

1948-
if (!pm_runtime_status_suspended(dev) || !dev->power.needs_force_resume)
1948+
if (!dev->power.needs_force_resume)
19491949
goto out;
19501950

19511951
/*

0 commit comments

Comments
 (0)