Skip to content

Commit d0660f9

Browse files
Charles Hantomba
authored andcommitted
drm: xlnx: zynqmp_dpsub: Add NULL check in zynqmp_audio_init
devm_kasprintf() calls can return null pointers on failure. But some return values were not checked in zynqmp_audio_init(). Add NULL check in zynqmp_audio_init(), avoid referencing null pointers in the subsequent code. Fixes: 3ec5c15 ("drm: xlnx: zynqmp_dpsub: Add DP audio support") Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Charles Han <hanchunchao@inspur.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250211102049.6468-1-hanchunchao@inspur.com
1 parent 28b529a commit d0660f9

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/gpu/drm/xlnx/zynqmp_dp_audio.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,12 +323,16 @@ int zynqmp_audio_init(struct zynqmp_dpsub *dpsub)
323323

324324
audio->dai_name = devm_kasprintf(dev, GFP_KERNEL,
325325
"%s-dai", dev_name(dev));
326+
if (!audio->dai_name)
327+
return -ENOMEM;
326328

327329
for (unsigned int i = 0; i < ZYNQMP_NUM_PCMS; ++i) {
328330
audio->link_names[i] = devm_kasprintf(dev, GFP_KERNEL,
329331
"%s-dp-%u", dev_name(dev), i);
330332
audio->pcm_names[i] = devm_kasprintf(dev, GFP_KERNEL,
331333
"%s-pcm-%u", dev_name(dev), i);
334+
if (!audio->link_names[i] || !audio->pcm_names[i])
335+
return -ENOMEM;
332336
}
333337

334338
audio->base = devm_platform_ioremap_resource_byname(pdev, "aud");

0 commit comments

Comments
 (0)