Skip to content

Commit cbf3fb5

Browse files
jdelvareAndi Shyti
authored andcommitted
i2c: designware: Fix the functionality flags of the slave-only interface
When an I2C adapter acts only as a slave, it should not claim to support I2C master capabilities. Fixes: 5b6d721 ("i2c: designware: enable SLAVE in platform module") Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Luis Oliveira <lolivei@synopsys.com> Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Mika Westerberg <mika.westerberg@linux.intel.com> Cc: Jan Dabros <jsd@semihalf.com> Cc: Andi Shyti <andi.shyti@kernel.org> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
1 parent d6d5645 commit cbf3fb5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/i2c/busses/i2c-designware-slave.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ static const struct i2c_algorithm i2c_dw_algo = {
220220

221221
void i2c_dw_configure_slave(struct dw_i2c_dev *dev)
222222
{
223-
dev->functionality = I2C_FUNC_SLAVE | DW_IC_DEFAULT_FUNCTIONALITY;
223+
dev->functionality = I2C_FUNC_SLAVE;
224224

225225
dev->slave_cfg = DW_IC_CON_RX_FIFO_FULL_HLD_CTRL |
226226
DW_IC_CON_RESTART_EN | DW_IC_CON_STOP_DET_IFADDRESSED;

0 commit comments

Comments
 (0)