Skip to content

Commit cbe82e1

Browse files
guoren83palmer-dabbelt
authored andcommitted
asm-generic: ticket-lock: Reuse arch_spinlock_t of qspinlock
The arch_spinlock_t of qspinlock has contained the atomic_t val, which satisfies the ticket-lock requirement. Thus, unify the arch_spinlock_t into qspinlock_types.h. This is the preparation for the next combo spinlock. Reviewed-by: Leonardo Bras <leobras@redhat.com> Suggested-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/linux-riscv/CAK8P3a2rnz9mQqhN6-e0CGUUv9rntRELFdxt_weiD7FxH7fkfQ@mail.gmail.com/ Signed-off-by: Guo Ren <guoren@kernel.org> Signed-off-by: Guo Ren <guoren@linux.alibaba.com> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Andrew Jones <ajones@ventanamicro.com> Reviewed-by: Andrea Parri <parri.andrea@gmail.com> Link: https://lore.kernel.org/r/20241103145153.105097-10-alexghiti@rivosinc.com Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
1 parent 97ddab7 commit cbe82e1

File tree

2 files changed

+9
-17
lines changed

2 files changed

+9
-17
lines changed

include/asm-generic/spinlock.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232

3333
static __always_inline void arch_spin_lock(arch_spinlock_t *lock)
3434
{
35-
u32 val = atomic_fetch_add(1<<16, lock);
35+
u32 val = atomic_fetch_add(1<<16, &lock->val);
3636
u16 ticket = val >> 16;
3737

3838
if (ticket == (u16)val)
@@ -46,31 +46,31 @@ static __always_inline void arch_spin_lock(arch_spinlock_t *lock)
4646
* have no outstanding writes due to the atomic_fetch_add() the extra
4747
* orderings are free.
4848
*/
49-
atomic_cond_read_acquire(lock, ticket == (u16)VAL);
49+
atomic_cond_read_acquire(&lock->val, ticket == (u16)VAL);
5050
smp_mb();
5151
}
5252

5353
static __always_inline bool arch_spin_trylock(arch_spinlock_t *lock)
5454
{
55-
u32 old = atomic_read(lock);
55+
u32 old = atomic_read(&lock->val);
5656

5757
if ((old >> 16) != (old & 0xffff))
5858
return false;
5959

60-
return atomic_try_cmpxchg(lock, &old, old + (1<<16)); /* SC, for RCsc */
60+
return atomic_try_cmpxchg(&lock->val, &old, old + (1<<16)); /* SC, for RCsc */
6161
}
6262

6363
static __always_inline void arch_spin_unlock(arch_spinlock_t *lock)
6464
{
6565
u16 *ptr = (u16 *)lock + IS_ENABLED(CONFIG_CPU_BIG_ENDIAN);
66-
u32 val = atomic_read(lock);
66+
u32 val = atomic_read(&lock->val);
6767

6868
smp_store_release(ptr, (u16)val + 1);
6969
}
7070

7171
static __always_inline int arch_spin_value_unlocked(arch_spinlock_t lock)
7272
{
73-
u32 val = lock.counter;
73+
u32 val = lock.val.counter;
7474

7575
return ((val >> 16) == (val & 0xffff));
7676
}
@@ -84,7 +84,7 @@ static __always_inline int arch_spin_is_locked(arch_spinlock_t *lock)
8484

8585
static __always_inline int arch_spin_is_contended(arch_spinlock_t *lock)
8686
{
87-
u32 val = atomic_read(lock);
87+
u32 val = atomic_read(&lock->val);
8888

8989
return (s16)((val >> 16) - (val & 0xffff)) > 1;
9090
}

include/asm-generic/spinlock_types.h

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,7 @@
33
#ifndef __ASM_GENERIC_SPINLOCK_TYPES_H
44
#define __ASM_GENERIC_SPINLOCK_TYPES_H
55

6-
#include <linux/types.h>
7-
typedef atomic_t arch_spinlock_t;
8-
9-
/*
10-
* qrwlock_types depends on arch_spinlock_t, so we must typedef that before the
11-
* include.
12-
*/
13-
#include <asm/qrwlock_types.h>
14-
15-
#define __ARCH_SPIN_LOCK_UNLOCKED ATOMIC_INIT(0)
6+
#include <asm-generic/qspinlock_types.h>
7+
#include <asm-generic/qrwlock_types.h>
168

179
#endif /* __ASM_GENERIC_SPINLOCK_TYPES_H */

0 commit comments

Comments
 (0)