NFSv4: clp->cl_cons_state < 0 signifies an invalid nfs_client

Trond Myklebust · Trond Myklebust · commit c81d5bcb7b38 · 2025-03-26T12:19:51.000-04:00
If someone calls nfs_mark_client_ready(clp, status) with a negative
value for status, then that should signal that the nfs_client is no
longer valid.

Reviewed-by: Jeff Layton &lt;jlayton@kernel.org&gt;
Reviewed-by: Benjamin Coddington &lt;bcodding@redhat.com&gt;
Signed-off-by: Trond Myklebust &lt;trond.myklebust@hammerspace.com&gt;
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
@@ -1403,7 +1403,7 @@ int nfs4_schedule_stateid_recovery(const struct nfs_server *server, struct nfs4_
 	dprintk("%s: scheduling stateid recovery for server %s\n", __func__,
 			clp->cl_hostname);
 	nfs4_schedule_state_manager(clp);
-	return 0;
+	return clp->cl_cons_state < 0 ? clp->cl_cons_state : 0;
 }
 EXPORT_SYMBOL_GPL(nfs4_schedule_stateid_recovery);
 

Original file line number	Diff line number	Diff line change
`@@ -1403,7 +1403,7 @@ int nfs4_schedule_stateid_recovery(const struct nfs_server *server, struct nfs4_`
`1403`	`1403`	`dprintk("%s: scheduling stateid recovery for server %s\n", __func__,`
`1404`	`1404`	`clp->cl_hostname);`
`1405`	`1405`	`nfs4_schedule_state_manager(clp);`
`1406`		`- return 0;`
	`1406`	`+ return clp->cl_cons_state < 0 ? clp->cl_cons_state : 0;`
`1407`	`1407`	`}`
`1408`	`1408`	`EXPORT_SYMBOL_GPL(nfs4_schedule_stateid_recovery);`
`1409`	`1409`