Skip to content

Commit c5a2193

Browse files
glneobroonie
authored andcommitted
regmap: Move selecting for REGMAP_MDIO and REGMAP_IRQ
If either REGMAP_IRQ or REGMAP_MDIO are set then REGMAP is also set. This then enables the selecting of IRQ_DOMAIN or MDIO_BUS from REGMAP based on the above two symbols respectively. This makes it very easy to end up with "circular dependencies". Instead select the IRQ_DOMAIN or MDIO_BUS from the symbols that make use of them. This is almost equivalent to before but makes it less likely to end up with false circular dependency detections. Signed-off-by: Andrew Davis <afd@ti.com> Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Closes: https://lore.kernel.org/r/bfe991fa-f54c-4d58-b2e0-34c4e4eb48f4@linaro.org/ Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://patch.msgid.link/20250516141722.13772-1-afd@ti.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent d30e845 commit c5a2193

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/base/regmap/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
config REGMAP
77
bool
88
default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SOUNDWIRE || REGMAP_SOUNDWIRE_MBQ || REGMAP_SCCB || REGMAP_I3C || REGMAP_SPI_AVMM || REGMAP_MDIO || REGMAP_FSI)
9-
select IRQ_DOMAIN if REGMAP_IRQ
10-
select MDIO_BUS if REGMAP_MDIO
119
help
1210
Enable support for the Register Map (regmap) access API.
1311

@@ -58,12 +56,14 @@ config REGMAP_W1
5856

5957
config REGMAP_MDIO
6058
tristate
59+
select MDIO_BUS
6160

6261
config REGMAP_MMIO
6362
tristate
6463

6564
config REGMAP_IRQ
6665
bool
66+
select IRQ_DOMAIN
6767

6868
config REGMAP_RAM
6969
tristate

0 commit comments

Comments
 (0)