Skip to content

Commit c4d6b54

Browse files
svens-s390rostedt
authored andcommitted
tracing/synthetic: Allocate one additional element for size
While debugging another issue I noticed that the stack trace contains one invalid entry at the end: <idle>-0 [008] d..4. 26.484201: wake_lat: pid=0 delta=2629976084 000000009cc24024 stack=STACK: => __schedule+0xac6/0x1a98 => schedule+0x126/0x2c0 => schedule_timeout+0x150/0x2c0 => kcompactd+0x9ca/0xc20 => kthread+0x2f6/0x3d8 => __ret_from_fork+0x8a/0xe8 => 0x6b6b6b6b6b6b6b6b This is because the code failed to add the one element containing the number of entries to field_size. Link: https://lkml.kernel.org/r/20230816154928.4171614-4-svens@linux.ibm.com Cc: Masami Hiramatsu <mhiramat@kernel.org> Fixes: 00cf3d6 ("tracing: Allow synthetic events to pass around stacktraces") Signed-off-by: Sven Schnelle <svens@linux.ibm.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent 887f92e commit c4d6b54

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

kernel/trace/trace_events_synth.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,8 @@ static notrace void trace_event_raw_event_synth(void *__data,
528528
str_val = (char *)(long)var_ref_vals[val_idx];
529529

530530
if (event->dynamic_fields[i]->is_stack) {
531-
len = *((unsigned long *)str_val);
531+
/* reserve one extra element for size */
532+
len = *((unsigned long *)str_val) + 1;
532533
len *= sizeof(unsigned long);
533534
} else {
534535
len = fetch_store_strlen((unsigned long)str_val);

0 commit comments

Comments
 (0)