Skip to content

Commit c19fa08

Browse files
bingbucaoHans Verkuil
authored andcommitted
media: intel/ipu6: fix the buffer flags caused by wrong parentheses
The buffer flags is set by wrong due to wrong parentheses, the FL_INCOMING flag is never taken an account. Fix it by wrapping the ternary conditional operation with parentheses. Fixes: 3c1dfb5 ("media: intel/ipu6: input system video nodes and buffer queues") Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
1 parent ab0ed48 commit c19fa08

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/media/pci/intel/ipu6/ipu6-isys-queue.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -301,10 +301,10 @@ static int ipu6_isys_stream_start(struct ipu6_isys_video *av,
301301
out_requeue:
302302
if (bl && bl->nbufs)
303303
ipu6_isys_buffer_list_queue(bl,
304-
(IPU6_ISYS_BUFFER_LIST_FL_INCOMING |
305-
error) ?
304+
IPU6_ISYS_BUFFER_LIST_FL_INCOMING |
305+
(error ?
306306
IPU6_ISYS_BUFFER_LIST_FL_SET_STATE :
307-
0, error ? VB2_BUF_STATE_ERROR :
307+
0), error ? VB2_BUF_STATE_ERROR :
308308
VB2_BUF_STATE_QUEUED);
309309
flush_firmware_streamon_fail(stream);
310310

0 commit comments

Comments
 (0)