Skip to content

Commit bcfb443

Browse files
raagjadavgregkh
authored andcommitted
pps: generators: tio: fix platform_set_drvdata()
platform_set_drvdata() is setting a double pointer to struct pps_tio as driver_data, which will point to the local stack of probe function instead of intended data. Set driver_data correctly and fix illegal memory access by its user. BUG: unable to handle page fault for address: ffffc9000117b738 RIP: 0010:hrtimer_active+0x2b/0x60 Call Trace: ? hrtimer_active+0x2b/0x60 hrtimer_cancel+0x19/0x50 pps_gen_tio_remove+0x1e/0x80 [pps_gen_tio] Fixes: c89755d ("pps: generators: Add PPS Generator TIO Driver") Signed-off-by: Raag Jadav <raag.jadav@intel.com> Acked-by: Rodolfo Giometti <giometti@enneenne.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20250318114038.2058677-1-raag.jadav@intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 7c7f1bf commit bcfb443

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pps/generators/pps_gen_tio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ static int pps_gen_tio_probe(struct platform_device *pdev)
230230
hrtimer_setup(&tio->timer, hrtimer_callback, CLOCK_REALTIME,
231231
HRTIMER_MODE_ABS);
232232
spin_lock_init(&tio->lock);
233-
platform_set_drvdata(pdev, &tio);
233+
platform_set_drvdata(pdev, tio);
234234

235235
return 0;
236236
}

0 commit comments

Comments
 (0)