Skip to content

Commit bc8ab44

Browse files
committed
drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_cleanup_done()
drm_atomic_helper_wait_for_dependencies() is the final part of a commit and signals it completion. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/20250213-bridge-connector-v3-25-e71598f49c8f@kernel.org Signed-off-by: Maxime Ripard <mripard@kernel.org>
1 parent 6280e96 commit bc8ab44

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/gpu/drm/drm_atomic_helper.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2562,23 +2562,23 @@ EXPORT_SYMBOL(drm_atomic_helper_commit_hw_done);
25622562

25632563
/**
25642564
* drm_atomic_helper_commit_cleanup_done - signal completion of commit
2565-
* @old_state: atomic state object with old state structures
2565+
* @state: atomic state object being committed
25662566
*
2567-
* This signals completion of the atomic update @old_state, including any
2567+
* This signals completion of the atomic update @state, including any
25682568
* cleanup work. If used, it must be called right before calling
25692569
* drm_atomic_state_put().
25702570
*
25712571
* This is part of the atomic helper support for nonblocking commits, see
25722572
* drm_atomic_helper_setup_commit() for an overview.
25732573
*/
2574-
void drm_atomic_helper_commit_cleanup_done(struct drm_atomic_state *old_state)
2574+
void drm_atomic_helper_commit_cleanup_done(struct drm_atomic_state *state)
25752575
{
25762576
struct drm_crtc *crtc;
25772577
struct drm_crtc_state *old_crtc_state;
25782578
struct drm_crtc_commit *commit;
25792579
int i;
25802580

2581-
for_each_old_crtc_in_state(old_state, crtc, old_crtc_state, i) {
2581+
for_each_old_crtc_in_state(state, crtc, old_crtc_state, i) {
25822582
commit = old_crtc_state->commit;
25832583
if (WARN_ON(!commit))
25842584
continue;
@@ -2591,9 +2591,9 @@ void drm_atomic_helper_commit_cleanup_done(struct drm_atomic_state *old_state)
25912591
spin_unlock(&crtc->commit_lock);
25922592
}
25932593

2594-
if (old_state->fake_commit) {
2595-
complete_all(&old_state->fake_commit->cleanup_done);
2596-
WARN_ON(!try_wait_for_completion(&old_state->fake_commit->hw_done));
2594+
if (state->fake_commit) {
2595+
complete_all(&state->fake_commit->cleanup_done);
2596+
WARN_ON(!try_wait_for_completion(&state->fake_commit->hw_done));
25972597
}
25982598
}
25992599
EXPORT_SYMBOL(drm_atomic_helper_commit_cleanup_done);

0 commit comments

Comments
 (0)