Skip to content

Commit b967c4b

Browse files
author
Wolfram Sang
committed
Revert "i2c: amd756: Fix endianness handling for word data"
This reverts commit 70f3d36. We concluded that removing the comments is the right thing to do. This will be done by an incremental patch. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
1 parent a46fe1f commit b967c4b

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/i2c/busses/i2c-amd756.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
#include <linux/i2c.h>
3232
#include <linux/acpi.h>
3333
#include <linux/io.h>
34-
#include <linux/byteorder/generic.h>
3534

3635
/* AMD756 SMBus address offsets */
3736
#define SMB_ADDR_OFFSET 0xE0
@@ -212,7 +211,7 @@ static s32 amd756_access(struct i2c_adapter * adap, u16 addr,
212211
SMB_HOST_ADDRESS);
213212
outb_p(command, SMB_HOST_COMMAND);
214213
if (read_write == I2C_SMBUS_WRITE)
215-
outw_p(cpu_to_le16((u16)data->word), SMB_HOST_DATA);
214+
outw_p(data->word, SMB_HOST_DATA); /* TODO: endian???? */
216215
size = AMD756_WORD_DATA;
217216
break;
218217
case I2C_SMBUS_BLOCK_DATA:
@@ -257,7 +256,7 @@ static s32 amd756_access(struct i2c_adapter * adap, u16 addr,
257256
data->byte = inw_p(SMB_HOST_DATA);
258257
break;
259258
case AMD756_WORD_DATA:
260-
data->word = (u16)le16_to_cpu(inw_p(SMB_HOST_DATA));
259+
data->word = inw_p(SMB_HOST_DATA); /* TODO: endian???? */
261260
break;
262261
case AMD756_BLOCK_DATA:
263262
data->block[0] = inw_p(SMB_HOST_DATA) & 0x3f;

0 commit comments

Comments
 (0)